-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polkadot-parachain: Remove shell node #5911
Merged
serban300
merged 5 commits into
paritytech:master
from
serban300:polkadot-parachain-shell-node
Oct 4, 2024
Merged
polkadot-parachain: Remove shell node #5911
serban300
merged 5 commits into
paritytech:master
from
serban300:polkadot-parachain-shell-node
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skunert
approved these changes
Oct 2, 2024
kianenigma
approved these changes
Oct 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 3, 2024
You should also remove the shell/seedling runtimes, no? |
Good point ! Thanks ! Totally missed that. Done. |
Merged
via the queue into
paritytech:master
with commit Oct 4, 2024
261b3da
207 of 208 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the shell node variant for the polkadot-parachain as discussed here: #5586 (comment)
Resolves #5898