Skip to content

fix prospective parachains test to use shuffled candidate list #5880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2024
Merged

fix prospective parachains test to use shuffled candidate list #5880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
675fa2d
fix prospective parachains test to use suffled candidate list
alindima Oct 1, 2024
22350f5
add prdoc
alindima Oct 1, 2024
8c0269c
Merge branch 'master' into alindima/fix-test
alindima Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion polkadot/node/core/prospective-parachains/src/fragment_chain/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1433,7 +1433,7 @@ fn test_find_ancestor_path_and_find_backable_chain() {
// Now back all candidates. Back them in a random order. The result should always be the same.
let mut candidates_shuffled = candidates.clone();
candidates_shuffled.shuffle(&mut thread_rng());
for candidate in candidates.iter() {
for candidate in candidates_shuffled.iter() {
chain.candidate_backed(candidate);
storage.mark_backed(candidate);
}
Expand Down
11 changes: 11 additions & 0 deletions prdoc/pr_5880.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
title: Fix prospective parachains test to use shuffled candidate list

doc:
- audience: Node Dev
description: |
Fix prospective parachains test to use shuffled candidate list.
Resolves https://github.com/paritytech/polkadot-sdk/issues/5617.

crates:
- name: polkadot-node-core-prospective-parachains
bump: none