Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pallet-revive] uapi: allow create1 equivalent calls #5701

Merged
merged 5 commits into from
Sep 13, 2024
Merged

[pallet-revive] uapi: allow create1 equivalent calls #5701

merged 5 commits into from
Sep 13, 2024

Conversation

xermicus
Copy link
Member

The salt argument should be optional to allow create1 equivalent calls.

@xermicus xermicus added R0-silent Changes should not be mentioned in any release notes T7-smart_contracts This PR/Issue is related to smart contracts. labels Sep 13, 2024
@xermicus xermicus marked this pull request as ready for review September 13, 2024 09:07
@xermicus xermicus requested review from athei and pgherveou September 13, 2024 09:17
athei
athei reviewed Sep 13, 2024
View reviewed changes
substrate/frame/revive/fixtures/contracts/create1_with_value.rs Outdated
Comment on lines 27 to 28
//let value = u64_output!(api::value_transferred,);
//assert_ne!(value, 0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove commented code

Copy link
Member Author

@xermicus xermicus Sep 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks

@xermicus xermicus requested a review from athei September 13, 2024 09:45
athei
athei approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Forgot to adapt the uapi when changing the behaviour.

@xermicus xermicus enabled auto-merge September 13, 2024 09:53
@xermicus xermicus added this pull request to the merge queue Sep 13, 2024
Merged via the queue into master with commit b21da74 Sep 13, 2024
205 of 207 checks passed
@xermicus xermicus deleted the cl/create1 branch September 13, 2024 11:08
@athei athei mentioned this pull request Nov 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athei athei athei approved these changes

@pgherveou pgherveou pgherveou approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T7-smart_contracts This PR/Issue is related to smart contracts.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xermicus @pgherveou @athei