Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Hub: auto incremented asset id for trust backed assets #5687

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Asset Hub: auto incremented asset id for trust backed assets #5687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19f7db9
auto incremented asset id for trust backed assets
muharem Sep 12, 2024
8e7294a
pr doc
muharem Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ impl pallet_assets::Config<TrustBackedAssetsInstance> for Runtime {
type Freezer = AssetsFreezer;
type Extra = ();
type WeightInfo = weights::pallet_assets_local::WeightInfo<Runtime>;
type CallbackHandle = ();
type CallbackHandle = pallet_assets::AutoIncAssetId<Runtime, TrustBackedAssetsInstance>;
type AssetAccountDeposit = AssetAccountDeposit;
type RemoveItemsLimit = frame_support::traits::ConstU32<1000>;
#[cfg(feature = "runtime-benchmarks")]
Expand Down Expand Up @@ -1019,6 +1019,12 @@ pub type Migrations = (
cumulus_pallet_xcmp_queue::migration::v5::MigrateV4ToV5<Runtime>,
pallet_collator_selection::migration::v2::MigrationToV2<Runtime>,
frame_support::migrations::RemovePallet<StateTrieMigrationName, RocksDbWeight>,
// unreleased
pallet_assets::migration::next_asset_id::SetNextAssetId<
ConstU32<50_000_000>,
Runtime,
TrustBackedAssetsInstance,
>,
// permanent
pallet_xcm::migration::MigrateToLatestXcmVersion<Runtime>,
);
Expand Down
8 changes: 7 additions & 1 deletion cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ impl pallet_assets::Config<TrustBackedAssetsInstance> for Runtime {
type Freezer = AssetsFreezer;
type Extra = ();
type WeightInfo = weights::pallet_assets_local::WeightInfo<Runtime>;
type CallbackHandle = ();
type CallbackHandle = pallet_assets::AutoIncAssetId<Runtime, TrustBackedAssetsInstance>;
type AssetAccountDeposit = AssetAccountDeposit;
type RemoveItemsLimit = ConstU32<1000>;
#[cfg(feature = "runtime-benchmarks")]
Expand Down Expand Up @@ -1021,6 +1021,12 @@ pub type Migrations = (
// unreleased
cumulus_pallet_xcmp_queue::migration::v4::MigrationToV4<Runtime>,
cumulus_pallet_xcmp_queue::migration::v5::MigrateV4ToV5<Runtime>,
// unreleased
pallet_assets::migration::next_asset_id::SetNextAssetId<
ConstU32<50_000_000>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about defining and naming a const under runtimes/constants/ instead of having this magic number here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be gone after the migration applied

Runtime,
TrustBackedAssetsInstance,
>,
// permanent
pallet_xcm::migration::MigrateToLatestXcmVersion<Runtime>,
);
Expand Down
24 changes: 24 additions & 0 deletions prdoc/pr_5687.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0
# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json

title: "Westend/Rococo Asset Hub: auto incremented asset id for trust backed assets"

doc:
- audience: Runtime User
description: |
Setup auto incremented asset id to `50_000_000` for trust backed assets.

### Migration
This change does not break the API but introduces a new constraint. It implements
an auto-incremented ID strategy for Trust-Backed Assets (50 pallet instance indexes on both
networks), starting at ID 50,000,000. Each new asset must be created with an ID that is one
greater than the last asset created. The next ID can be fetched from the `NextAssetId`
storage item of the assets pallet. An empty `NextAssetId` storage item indicates no
constraint on the next asset ID and can serve as a feature flag for this release.


crates:
- name: asset-hub-rococo-runtime
bump: major
- name: asset-hub-westend-runtime
bump: major
Loading