Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2407] Backport #5466 #5524

Merged
merged 5 commits into from
Sep 10, 2024
Merged

[stable2407] Backport #5466 #5524

merged 5 commits into from
Sep 10, 2024

Conversation

github-actions[bot]
Copy link

Backport #5466 into stable2407 (cc @ggwpez).

Copy link
Author

github-actions bot commented Aug 29, 2024

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or trivial (not sure audit).
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Aug 29, 2024
Changes:
- Set default level to `Info` again. Seems like a dependency update set
it to something higher.
- Fix docs to not use `--locked` since we rely on dependency bumps via
cargo.
- Add README with rust docs.
- Fix bug where the node ignored `--heap-pages` argument.

You can test the `--heap-pages` bug by running this command on master
and then on this branch. Note that it should fail because of the very
low heap pages arg:
`cargo run --release --bin polkadot --features=runtime-benchmarks --
benchmark pallet --chain=dev --steps=10 --repeat=30
--wasm-execution=compiled --heap-pages=8 --pallet=frame-system
--extrinsic="*"`

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: ggwpez <[email protected]>
(cherry picked from commit 7e7c334)
@ggwpez ggwpez force-pushed the backport-5466-to-stable2407 branch from d7299ac to 51bf026 Compare August 29, 2024 15:35
ggwpez added 2 commits August 29, 2024 17:37
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7188203

@ggwpez ggwpez marked this pull request as ready for review September 9, 2024 12:04
@bkchr bkchr merged commit 38945d0 into stable2407 Sep 10, 2024
147 of 187 checks passed
@bkchr bkchr deleted the backport-5466-to-stable2407 branch September 10, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants