Add feature to allow Aura collator to use full PoV size #5393
Conversation
|
why it is a feature flag instead of some parameter passed in? |
I just don't see much sense in punching holes in the Aura parameter structures (three of them, to be precise) for something that is obviously transient. The feature allows for keeping the change footprint small. Besides that, changing the collator parameters is a breaking change. This one with the feature could be backported if need be, but with the parameter, it's not possible. |
|
This should be removed entirely when the time has come. I don't see any reason that we should backport or bring this up as a feature flag. With the next stable release in 5 months we hopefully have ironed out all the bugs we can remove it. |
My brain was not working. As benchmarking ensures that we don't run over the PoV limit, I think we can just remove the training wheels. The So, I would advocate to remove the division by two completely. Nevertheless, we should ensure to backport all the fixes for pov reclaim to ensure that if people are using it, it is secure. |
Co-authored-by: Andrei Sandu <[email protected]>
This PR introduces a feature that allows to optionally enable using the full PoV size. Technically, we're ready to enable it by default, but as corresponding runtime changes have not been propagated to the system parachain runtimes yet, doing so could put them at risk. On the other hand, there are teams that could benefit from it right now, and it makes no sense for them to wait for the fellowship release and everything. --------- Co-authored-by: Andrei Sandu <[email protected]>
…5393) (#5507) This PR introduces a feature that allows to optionally enable using the full PoV size. Technically, we're ready to enable it by default, but as corresponding runtime changes have not been propagated to the system parachain runtimes yet, doing so could put them at risk. On the other hand, there are teams that could benefit from it right now, and it makes no sense for them to wait for the fellowship release and everything. --------- Co-authored-by: Andrei Sandu <[email protected]>
* master: (39 commits) short-term fix for para inherent weight overestimation (#5082) CI: Add backporting bot (#4795) Fix benchmark failures when using `insecure_zero_ed` flag (#5354) Command bot GHA v2 - /cmd <cmd> (#5457) Remove pallet::getter usage from treasury (#4962) Bump blake2b_simd from 1.0.1 to 1.0.2 (#5404) Bump rustversion from 1.0.14 to 1.0.17 (#5405) Bridge zombienet tests: remove old command (#5434) polkadot-parachain: Add omni-node variant with u64 block number (#5269) Refactor verbose test (#5506) Use umbrella crate for minimal template (#5155) IBP Coretime Polkadot bootnodes (#5499) rpc server: listen to `ipv6 socket` if available and `--experimental-rpc-endpoint` CLI option (#4792) Update approval-voting-regression-bench (#5504) change try-runtime rpc domains (#5443) polkadot-parachain-bin: Remove contracts parachain (#5471) Add feature to allow Aura collator to use full PoV size (#5393) Adding stkd bootnodes (#5470) Make `PendingConfigs` storage item public (#5467) frame-omni-bencher maintenance (#5466) ...
This PR introduces a feature that allows to optionally enable using the full PoV size.
Technically, we're ready to enable it by default, but as corresponding runtime changes have not been propagated to the system parachain runtimes yet, doing so could put them at risk. On the other hand, there are teams that could benefit from it right now, and it makes no sense for them to wait for the fellowship release and everything.