Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xcm] runtime api for LocationToAccount conversions #4857

Merged
merged 32 commits into from
Jun 26, 2024
Merged

[xcm] runtime api for LocationToAccount conversions #4857

merged 32 commits into from
Jun 26, 2024

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Jun 21, 2024 •
edited
Loading

Closes: #4298

This PR also merges xcm-fee-payment-runtime-api module to the xcm-runtime-api.

TODO

Open questions

  • should we merge xcm-runtime-api and xcm-fee-payment-runtime-api to the one module xcm-runtime-api ?

Usage

Input:

  • location: VersionedLocation

Output:

  • account_id bytes

image

@bkontur bkontur added the T6-XCM This PR/Issue is related to XCM. label Jun 21, 2024
@bkontur bkontur mentioned this pull request Jun 25, 2024
Merged
@bkontur bkontur mentioned this pull request Jun 25, 2024
Closed
@bkontur bkontur marked this pull request as ready for review June 25, 2024 09:16
@bkontur bkontur requested a review from a team as a code owner June 25, 2024 09:16
acatangiu
acatangiu approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

should we merge xcm-runtime-api and xcm-fee-payment-runtime-api to the one module xcm-runtime-api ?

that sounds good hygiene to me, makes sense to have a structure like:

xcm-runtime-api
|    mod conversions
|    mod dry_run
|    mod fees

@bkontur bkontur requested a review from bkchr June 26, 2024 08:59
bkchr
bkchr approved these changes Jun 26, 2024
View reviewed changes
cumulus/parachains/runtimes/collectives/collectives-westend/src/lib.rs Outdated Show resolved Hide resolved
prdoc/pr_4857.prdoc Show resolved Hide resolved
polkadot/xcm/xcm-runtime-api/src/conversions.rs Outdated Show resolved Hide resolved
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6554913

@bkontur bkontur enabled auto-merge June 26, 2024 12:33
franciscoaguirre
franciscoaguirre approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@franciscoaguirre franciscoaguirre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

polkadot/xcm/xcm-runtime-api/Cargo.toml Outdated Show resolved Hide resolved
polkadot/xcm/xcm-runtime-api/tests/conversions.rs Outdated Show resolved Hide resolved
prdoc/pr_4857.prdoc Outdated Show resolved Hide resolved
@bkontur bkontur disabled auto-merge June 26, 2024 12:45
@bkontur bkontur enabled auto-merge June 26, 2024 13:08
@bkontur bkontur added this pull request to the merge queue Jun 26, 2024
Merged via the queue into master with commit 7506956 Jun 26, 2024
153 of 159 checks passed
@bkontur bkontur deleted the bko-xcm-runtime-api branch June 26, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

@bkchr bkchr bkchr approved these changes

@acatangiu acatangiu acatangiu approved these changes

@BabakArtist BabakArtist BabakArtist approved these changes

Assignees
No one assigned
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime API for LocationToAccountId Conversion
6 participants
@bkontur @paritytech-cicd-pr @franciscoaguirre @bkchr @acatangiu @BabakArtist