Implements PoV export and local validation
#4640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull requests adds a new CLI flag to `polkadot-parachains` `--export-pov-to-path`. This CLI flag will instruct the node to export any `PoV` that it build locally to export to the given folder. Then these `PoV` files can be validated using the introduced `cumulus-pov-validator`. The combination of export and validation can be used for debugging parachain validation issues that may happen on the relay chain.
ordian
approved these changes
May 30, 2024
| async move { | ||
| let timestamp = sp_timestamp::InherentDataProvider::from_system_time(); | ||
|
|
||
| let slot_duration = cumulus_client_consensus_aura::slot_duration(&*client)?; |
There was a problem hiding this comment.
this change seems unrelated, what are the implications? added support for dynamic slot durations?
sandreim
approved these changes
May 31, 2024
| let duration = start.elapsed(); | ||
|
|
||
| match res { | ||
| Ok(_) => tracing::info!("Validation was successful"), |
There was a problem hiding this comment.
I would also add an option to decode the commitments as ValidationResult to a file for debugging purposes.
Closed
|
The CI pipeline was cancelled due to failure one of the required jobs. |
ordian
approved these changes
Jul 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
This pull requests adds a new CLI flag to `polkadot-parachains` `--export-pov-to-path`. This CLI flag will instruct the node to export any `PoV` that it build locally to export to the given folder. Then these `PoV` files can be validated using the introduced `cumulus-pov-validator`. The combination of export and validation can be used for debugging parachain validation issues that may happen on the relay chain.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds a new CLI flag to
polkadot-parachains--export-pov-to-path. This CLI flag will instruct the node to export anyPoVthat it build locally to export to the given folder. Then thesePoVfiles can be validated using the introducedcumulus-pov-validator. The combination of export and validation can be used for debugging parachain validation issues that may happen on the relay chain.