Remove pallet::getter macro from pallet-identity #4586
Conversation
|
@PolkadotDom ci is not happy |
reduce kitchensink bump to patch Co-authored-by: Oliver Tale-Yazdi <[email protected]>
|
The CI pipeline was cancelled due to failure one of the required jobs. |
prdoc/pr_4586.prdoc
Outdated
|
|
||
| crates: | ||
| - name: pallet-identity | ||
| bump: major |
There was a problem hiding this comment.
It also needs to mention pallet-alliance with a patch, since it was modified.
There was a problem hiding this comment.
it is not modified. the tests are not published
There was a problem hiding this comment.
Hadn't seen there was a none option. Have set the bumps to that.
|
@PolkadotDom this branch has conflicts. |
…s-pallet-identity
|
bot fmt |
|
@bkchr https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6788844 was started for your command Comment |
|
We are migrating the command bot to be a GitHub Action |
|
@bkchr Command |
9974a68
As per paritytech#3326, removes pallet::getter macro usage from the pallet-identity. The syntax `StorageItem::<T, I>::get()` should be used instead. Also makes all storage values public cc @muraca --------- Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: command-bot <>
As per #3326, removes pallet::getter macro usage from the pallet-identity. The syntax
StorageItem::<T, I>::get()should be used instead.Also makes all storage values public
cc @muraca