benchmarking: complete automatic weight sanity check PR#4020
benchmarking: complete automatic weight sanity check PR#4020dastansam wants to merge 31 commits intoparitytech:masterfrom
Conversation
dastansam
changed the title
ggwpez
left a comment
ggwpez
left a comment
There was a problem hiding this comment.
Going to approve since its technically correct, just some small improvements possible.
comments are resolved: most of the logs are removed/simplified and logged only for failing extrinsics |
|
@ggwpez could you review it one last time? |
ggwpez
left a comment
ggwpez
left a comment
There was a problem hiding this comment.
LGTM. cc @kianenigma in case you also want to take a look.
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
|
hey @kianenigma would appreciate your review on this. thanks! |
@kianenigma ping |
…o complete-weight-sanity-check
There was a problem hiding this comment.
Glad to see this completed!
Can it be done without breaking the API?
@ggwpez just worried if this will again introduce another versioing issue with omni bencher and runtimes out there. Some runtimes will not work because they are not up to date, etc etc.
Tbh if that is the case, I don't think this feature is worth it.
Ideally it can be added incrementally, as a new runtime api.
In any case @dastansam great job and I will issue a tip.
|
/tip medium |
|
@kianenigma A referendum for a medium (80 DOT) tip was successfully submitted for @dastansam (16FqwPZ8GRC5U5D4Fu7W33nA55ZXzXGWHwmbnE1eT6pxuqcT on polkadot). Referendum number: 1378. |
|
The referendum has appeared on Polkassembly. |
6 participants
should complete #1493
polkadot address: 16FqwPZ8GRC5U5D4Fu7W33nA55ZXzXGWHwmbnE1eT6pxuqcT