Coretime: Add request revenue info #3940
Conversation
| let value = | ||
| Balances::reducible_balance(&stash, Preservation::Expendable, Fortitude::Polite); |
There was a problem hiding this comment.
I would probably just take all of it, but not that important here for the test chain.
Co-authored-by: Bastian Köcher <[email protected]>
|
|
||
| message.push(mk_coretime_call::<T>(CoretimeCalls::NotifyRevenue((when, raw_revenue)))); | ||
|
|
||
| send_xcm::<T::SendXcm>(dest.clone(), Xcm(message))?; |
There was a problem hiding this comment.
We know that this will send with Root privilege? It will be necessary for the UnpaidExecution instruction. IMO this is where testing with xcm-emulator is worth it.
There was a problem hiding this comment.
Well, it works in manual zombienet tests and in integration tests, so I guess it's likely to be okay... But if someone could make it through the emulator that would be great!
cumulus/parachains/runtimes/coretime/coretime-rococo/src/coretime.rs
Outdated
Show resolved
Hide resolved
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
How do i integrate this into a runtime? PRdoc and or MR description should provide some integration advise for downstream teams. |
Well, it's a fair point, although I doubt the PRdoc is a good place for it... Anyway, I was going to start a PR in the fellowship repo to integrate it into Kusama first. |
Enables the
request_revenueandnotify_revenueparts of RFC 5 - Coretime InterfaceTODO:
Need to explicitly burn uncollected and dropped revenueAccumulate it insteadrequest_revenuesending on Coretime chain on Kusama and PolkadotFixes: #2209