[subsystem-benchmarks] Save results to json #3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiEres
changed the title
AndreiEres
added
R0-silent
ggwpez
reviewed
Mar 25, 2024
ggwpez
reviewed
Mar 25, 2024
ordian
reviewed
Mar 26, 2024
ordian
reviewed
Mar 26, 2024
alexggh
reviewed
Mar 26, 2024
| @@ -82,6 +82,25 @@ impl BenchmarkUsage { | |||
| _ => None, | |||
| } | |||
| } | |||
|
|
|||
| pub fn to_json(&self) -> color_eyre::eyre::Result<String> { | |||
There was a problem hiding this comment.
This is more like, to_chart_items, because you also have Serialize/Deserialize derived for this structure which ca produce Jsons
alexggh
reviewed
Mar 26, 2024
| @@ -151,3 +170,10 @@ impl ResourceUsage { | |||
| } | |||
|
|
|||
| type ResourceUsageCheck<'a> = (&'a str, f64, f64); | |||
|
|
|||
| #[derive(Debug, Serialize)] | |||
| pub struct ChartItem { | |||
There was a problem hiding this comment.
Is this a format our other tooling is expecting ?
There was a problem hiding this comment.
yes, added to the PR description
sandreim
reviewed
Mar 26, 2024
|
Also, would be great to share some screenshots of it in action 😁 |
Co-authored-by: ordian <[email protected]>
Added PR description. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
sandreim
approved these changes
Mar 26, 2024
alexggh
approved these changes
Mar 26, 2024
ggwpez
reviewed
Mar 26, 2024
dharjeezy
pushed a commit
to dharjeezy/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
Here we add the ability to save subsystem benchmark results in JSON format to display them as graphs To draw graphs, CI team will use [github-action-benchmark](https://github.com/benchmark-action/github-action-benchmark). Since we are using custom benchmarks, we need to prepare [a specific data type](https://github.com/benchmark-action/github-action-benchmark?tab=readme-ov-file#examples): ``` [ { "name": "CPU Load", "unit": "Percent", "value": 50 } ] ``` Then we'll get graphs like this:  [A live page with graphs](https://benchmark-action.github.io/github-action-benchmark/dev/bench/) --------- Co-authored-by: ordian <[email protected]>
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we add the ability to save subsystem benchmark results in JSON format to display them as graphs
To draw graphs, CI team will use github-action-benchmark. Since we are using custom benchmarks, we need to prepare a specific data type:
Then we'll get graphs like this:
A live page with graphs