rpc server: make possible to disable/enable batch requests #3364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
changed the title
niklasad1
force-pushed
the
na-rpc-batch-request-config
branch
from
f56ddc3
to
3d7dda8
Compare
niklasad1
commented
Feb 17, 2024
| @@ -399,6 +407,22 @@ impl CliConfiguration for RunCmd { | |||
| Ok(self.rpc_max_subscriptions_per_connection) | |||
| } | |||
|
|
|||
| fn rpc_buffer_capacity_per_connection(&self) -> Result<u32> { | |||
There was a problem hiding this comment.
Unrelated to this PR but I noticed that this was missing and only the default value will be used regardless whether someone is using --rpc-buffer-capacity-per-connection X
There was a problem hiding this comment.
Ooh this is the line I missed when I was looking at the PR and only noticed the batch config bits :)
jsdw
reviewed
Feb 19, 2024
niklasad1
commented
Feb 19, 2024
jsdw
approved these changes
Feb 19, 2024
niklasad1
changed the title
skunert
approved these changes
Feb 20, 2024
…o na-rpc-batch-request-config
niklasad1
commented
Feb 20, 2024
| @@ -133,6 +133,7 @@ check-runtime-migration-westend: | |||
| WASM: "westend_runtime.compact.compressed.wasm" | |||
| URI: "wss://westend-try-runtime-node.parity-chains.parity.io:443" | |||
| SUBCOMMAND_EXTRA_ARGS: "--no-weight-warnings" | |||
| allow_failure: true | |||
There was a problem hiding this comment.
"CI fix" to allow the job to fail
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
paritytech-ci
pushed a commit
that referenced
this pull request
Feb 20, 2024
The rationale behind this, is that it may be useful for some users actually disable RPC batch requests or limit them by length instead of the total size bytes of the batch. This PR adds two new CLI options: ``` --rpc-disable-batch-requests - disable batch requests on the server --rpc-max-batch-request-len <LEN> - limit batches to LEN on the server. ```
franciscoaguirre
pushed a commit
that referenced
this pull request
Feb 22, 2024
The rationale behind this, is that it may be useful for some users actually disable RPC batch requests or limit them by length instead of the total size bytes of the batch. This PR adds two new CLI options: ``` --rpc-disable-batch-requests - disable batch requests on the server --rpc-max-batch-request-len <LEN> - limit batches to LEN on the server. ```
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
…h#3364) The rationale behind this, is that it may be useful for some users actually disable RPC batch requests or limit them by length instead of the total size bytes of the batch. This PR adds two new CLI options: ``` --rpc-disable-batch-requests - disable batch requests on the server --rpc-max-batch-request-len <LEN> - limit batches to LEN on the server. ```
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationale behind this, is that it may be useful for some users actually disable RPC batch requests or limit them by length instead of the total size bytes of the batch.
This PR adds two new CLI options: