Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-informant: Respect --disable-log-color #3009

Merged
merged 5 commits into from
Jan 22, 2024
Merged

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Jan 21, 2024

Changes sc-informant to respect the --disable-log-color CLI flag.

Closes: #2795

Changes `sc-informant` to respect the `--disable-log-color` CLI flag.
@bkchr bkchr added the T0-node This PR/Issue is related to the topic “node”. label Jan 21, 2024
@bkchr bkchr requested a review from a team January 21, 2024 21:40
@michalkucharczyk michalkucharczyk requested a review from a team January 22, 2024 09:02
@@ -39,7 +39,7 @@ fn interval(duration: Duration) -> impl Stream<Item = ()> + Unpin {
/// The format to print telemetry output in.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this doc should be changed.
By definition telemetry is collection of remote information, but here we are displaying info coming from local node.

@bkchr bkchr enabled auto-merge January 22, 2024 09:56
@bkchr bkchr added this pull request to the merge queue Jan 22, 2024
Merged via the queue into master with commit deb72f4 Jan 22, 2024
124 checks passed
@bkchr bkchr deleted the bkchr-respect-color-cli branch January 22, 2024 12:36
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
Changes `sc-informant` to respect the `--disable-log-color` CLI flag.

Closes: paritytech#2795

---------

Co-authored-by: Michal Kucharczyk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some log messages print with color unconditionally
3 participants