Fix Pools 6->7 migration #2942
Merged
Fix Pools 6->7 migration #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
bkontur
reviewed
Jan 16, 2024
bkontur
added a commit
to bkontur/runtimes
that referenced
this pull request
Jan 16, 2024
Co-authored-by: Branislav Kontur <[email protected]>
bkontur
added a commit
to bkontur/runtimes
that referenced
this pull request
Jan 17, 2024
This comment was marked as resolved.
This comment was marked as resolved.
bkontur
added a commit
to bkontur/runtimes
that referenced
this pull request
Jan 22, 2024
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
kianenigma
reviewed
Jan 23, 2024
kianenigma
approved these changes
Jan 23, 2024
Ank4n
approved these changes
Jan 23, 2024
rossbulat
reviewed
Jan 23, 2024
| - audience: Node Dev | ||
| description: | | ||
| Restores the behaviour of the nomination pools `V6ToV7` migration so that it still works when | ||
| the pallet will be upgraded to V8 afterwards. |
There was a problem hiding this comment.
This description doesn't make sense to me, V6ToV7 will work regardless of V8 as it is always migrated before V8 right? Or is it fixing something that mod v8 broke?
There was a problem hiding this comment.
V6ToV7 will work regardless
No sadly not. It should though - which is what this MR is correcting.
The migration tries to access storage from crate::pallet::BondedPoolInner etc, but this could still be unmigrated since the V8 migration could run afterwards.
It did work fine in the past, because the pallet storage definitions were not changed to V8 yet.
rossbulat
approved these changes
Jan 23, 2024
liamaharon
reviewed
Jan 23, 2024
8 tasks
bkontur
added a commit
to bkontur/runtimes
that referenced
this pull request
Jan 23, 2024
@ggwpez What is the status here? Any estimate? I am just asking because of this fellows bump. Thank you :) |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
bkontur
added a commit
to bkontur/runtimes
that referenced
this pull request
Jan 26, 2024
|
I've tested final version in |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
bkontur
pushed a commit
that referenced
this pull request
Jan 26, 2024
bkontur
pushed a commit
that referenced
this pull request
Jan 26, 2024
al3mart
pushed a commit
that referenced
this pull request
Jan 29, 2024
Fix the Pools `v7` migration. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Branislav Kontur <[email protected]>
acatangiu
pushed a commit
that referenced
this pull request
Feb 1, 2024
This should result as a patched `25.0.1` version for https://crates.io/crates/pallet-nomination-pools/25.0.0. Relates to: polkadot-fellows/runtimes#159 Co-authored-by: Oliver Tale-Yazdi <[email protected]>
claravanstaden
pushed a commit
to Snowfork/runtimes
that referenced
this pull request
Feb 5, 2024
claravanstaden
pushed a commit
to Snowfork/runtimes
that referenced
this pull request
Feb 5, 2024
acatangiu
added a commit
that referenced
this pull request
Feb 6, 2024
This should result as a patched `24.0.1` version for https://crates.io/crates/pallet-nomination-pools/24.0.0. Relates to: polkadot-fellows/runtimes#137 --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Alexander Samusev <[email protected]> Co-authored-by: Dónal Murray <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: PG Herveou <[email protected]>
bkontur
added a commit
that referenced
this pull request
Feb 6, 2024
This should result as a patched `24.0.1` version for https://crates.io/crates/pallet-nomination-pools/24.0.0. Relates to: polkadot-fellows/runtimes#137 --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Alexander Samusev <[email protected]> Co-authored-by: Dónal Murray <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: PG Herveou <[email protected]>
bkontur
added a commit
that referenced
this pull request
Feb 6, 2024
This should result as a patched `25.0.1` version for https://crates.io/crates/pallet-nomination-pools/25.0.0. Relates to: polkadot-fellows/runtimes#159 Co-authored-by: Oliver Tale-Yazdi <[email protected]>
acatangiu
pushed a commit
that referenced
this pull request
Feb 12, 2024
This is a cherry-pick of #3093 (patch to `release-polkadot-v1.6.0`). This should result as a patched `25.0.1` version for https://crates.io/crates/pallet-nomination-pools/25.0.0. Relates to: polkadot-fellows/runtimes#159 --------- Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: PG Herveou <[email protected]>
acatangiu
added a commit
that referenced
this pull request
Feb 12, 2024
This is a cherry-pick of #3094 (patch to `release-polkadot-v1.5.0`). This should result as a patched `24.0.1` version for https://crates.io/crates/pallet-nomination-pools/24.0.0. Relates to: polkadot-fellows/runtimes#137 --------- --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Alexander Samusev <[email protected]> Co-authored-by: Dónal Murray <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: PG Herveou <[email protected]> Co-authored-by: command-bot <>
This was referenced Feb 13, 2024
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
Fix the Pools `v7` migration. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Branislav Kontur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Pools
v7migration.