Dispatchable Call for Swapping Treasury Asset #2939
Conversation
muharem
changed the title
muharem
changed the title
muharem
added
R0-silent
...s/parachains/integration-tests/emulated/tests/assets/asset-hub-westend/src/tests/treasury.rs
Outdated
Show resolved
Hide resolved
| match ensure_signed(origin.clone()) { | ||
| Err(e) if T::SpendOrigin::ensure_origin(origin).is_err() => Err(e), | ||
| _ => Ok(()), | ||
| }?; |
There was a problem hiding this comment.
nit: This could be a separate function.
Is the reason we try the check for SpendOrigin because the call coming from the XCM in the test is not actually a signed origin, but an XCM origin?
There was a problem hiding this comment.
Yes.
Might be any pallets origin, not only XCM.
...s/parachains/integration-tests/emulated/tests/assets/asset-hub-westend/src/tests/treasury.rs
Outdated
Show resolved
Hide resolved
| EnsureSignedBy< | ||
| impls::MemberByLocation< | ||
| xcm_config::RelayTreasuryVoice, | ||
| xcm_config::LocationToAccountId, | ||
| AccountId, | ||
| >, | ||
| AccountId, | ||
| >, |
There was a problem hiding this comment.
XCM Transact instruction to swap treasury funds received with SovereignAccount origin kind, because swap calls must be signed by AccountId. The swap calls are not executed with Transact instruction, but scheduled with the schedule call, which is permissioned with this ScheduleOrigin type. This is why we need to EnsureSignedBy here.
There was a problem hiding this comment.
Alternatively same can be achieved if a call requiring an account will be wrapped with a call like dispatch_as_account: #4197
| @@ -13,7 +13,8 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| use crate::*; | |||
| // use crate::*; | |||
There was a problem hiding this comment.
| // use crate::*; |
Presenting a dispatchable call executed in the integration test environment, where the treasury's native asset is swapped for another asset on Asset Hub through the asset conversion pallet instance.
The swaps can be split into multiple swaps with retries to implement the DCA model.
The purpose of this PR is to explore and demonstrate the potential for swapping and diversifying treasury assets.