Fix node-metrics test
#1287
Merged
Fix node-metrics test
#1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
added
A1-insubstantial
pepoviola
approved these changes
Aug 29, 2023
gilescope
approved these changes
Aug 29, 2023
ggwpez
approved these changes
Aug 29, 2023
|
I think there are some more old scripts in the Cumulus and Substrate folder, but AFAIK @alvicsam wanted to clean them up eventually. |
ordian
approved these changes
Aug 29, 2023
| @@ -196,6 +196,8 @@ test-node-metrics: | |||
| # but still want to have debug assertions. | |||
| RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" | |||
There was a problem hiding this comment.
not introduced here, but we should remove this "-Cdebug-assertions=y" since we're using testnet profile for tests
alvicsam
approved these changes
Aug 30, 2023
sergejparity
approved these changes
Aug 30, 2023
bkchr
added a commit
that referenced
this pull request
Aug 30, 2023
Daanvdplas
pushed a commit
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request also removes old CI scripts.