Skip to content

WAH: wire pallet-recovery into benchmark list#12171

Merged
sigurpol merged 9 commits into
masterfrom
sigurpol-wah-revive-use-proper-weights
May 22, 2026
Merged

WAH: wire pallet-recovery into benchmark list#12171
sigurpol merged 9 commits into
masterfrom
sigurpol-wah-revive-use-proper-weights

Conversation

@sigurpol

@sigurpol sigurpol commented May 22, 2026

Copy link
Copy Markdown
Contributor
  • Wired pallet-recovery into the asset-hub-westend benchmark list.
  • Fixed the benchmark setup: finish_attempt / cancel_attempt advance frame_system's block number, which does not move RelaychainDataProvider, causing NotYetInheritable / NotYetCancelable. Under runtime-benchmarks, use frame_system as the BlockNumberProvider so the time-delay guards can be satisfied.

Note: similar fix in fellowship repo here as part of integration of SDK 2604.

Recovery benchmarks for finish_attempt / cancel_attempt advance frame_system's
block number, which does not move RelaychainDataProvider, causing
NotYetInheritable / NotYetCancelable.
Use frame_system under the benchmarking feature so the time-delay guards can be
satisfied.
@sigurpol sigurpol added the T12-benchmarks This PR/Issue is related to benchmarking and weights. label May 22, 2026
@sigurpol

Copy link
Copy Markdown
Contributor Author

/cmd prdoc --audience runtime_dev --bump patch

@github-actions

Copy link
Copy Markdown
Contributor

Command "prdoc --audience runtime_dev --bump" has failed ❌! See logs here

@paritytech-workflow-stopper

Copy link
Copy Markdown

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/26293345139
Failed job name: check-runtime-compatibility

@sigurpol sigurpol changed the title WAH: fix recovery benchmarks WAH: wire pallet-recovery into benchmark list May 22, 2026
@sigurpol

Copy link
Copy Markdown
Contributor Author

/cmd bench --runtime asset-hub-westend --pallet=pallet_recovery

@sigurpol sigurpol requested review from a team and ggwpez May 22, 2026 16:00
@github-actions

Copy link
Copy Markdown
Contributor

Command "bench --runtime asset-hub-westend --pallet=pallet_recovery" has started 🚀 See logs here

@github-actions

Copy link
Copy Markdown
Contributor

Command "bench --runtime asset-hub-westend --pallet=pallet_recovery" has finished ✅ See logs here

Details

Subweight results:
File Extrinsic Old New Change [%]
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_recovery.rs slash_attempt 660.48us Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_recovery.rs set_friend_groups 278.24us Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_recovery.rs revoke_inheritor 440.13us Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_recovery.rs initiate_attempt 633.00us Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_recovery.rs finish_attempt 1.07ms Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_recovery.rs control_inherited_account 46.35us Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_recovery.rs cancel_attempt 583.48us Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_recovery.rs approve_attempt 239.70us Added
Command output:

✅ Successful benchmarks of runtimes/pallets:
-- asset-hub-westend: ['pallet_recovery']

@sigurpol sigurpol requested review from a team and Szegoo May 22, 2026 17:58
@sigurpol sigurpol added this pull request to the merge queue May 22, 2026
Merged via the queue into master with commit 1aeb6ec May 22, 2026
321 of 322 checks passed
@sigurpol sigurpol deleted the sigurpol-wah-revive-use-proper-weights branch May 22, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T12-benchmarks This PR/Issue is related to benchmarking and weights.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants