WAH: wire pallet-recovery into benchmark list#12171
Merged
Merged
Conversation
Recovery benchmarks for finish_attempt / cancel_attempt advance frame_system's block number, which does not move RelaychainDataProvider, causing NotYetInheritable / NotYetCancelable. Use frame_system under the benchmarking feature so the time-delay guards can be satisfied.
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump patch |
…time_dev --bump patch'
Contributor
|
Command "prdoc --audience runtime_dev --bump" has failed ❌! See logs here |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Contributor
Author
|
/cmd bench --runtime asset-hub-westend --pallet=pallet_recovery |
Contributor
|
Command "bench --runtime asset-hub-westend --pallet=pallet_recovery" has started 🚀 See logs here |
ggwpez
approved these changes
May 22, 2026
…t-hub-westend --pallet=pallet_recovery'
Contributor
|
Command "bench --runtime asset-hub-westend --pallet=pallet_recovery" has finished ✅ See logs here DetailsSubweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
Szegoo
approved these changes
May 22, 2026
bkontur
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pallet-recoveryinto the asset-hub-westend benchmark list.finish_attempt/cancel_attemptadvanceframe_system's block number, which does not moveRelaychainDataProvider, causingNotYetInheritable/NotYetCancelable. Underruntime-benchmarks, useframe_systemas theBlockNumberProviderso the time-delay guards can be satisfied.Note: similar fix in fellowship repo here as part of integration of SDK 2604.