Skip to content

wip/sync: Force peers into ancestry search when blocks are not locally known #11917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lexnv wants to merge 2 commits into
base: master
Choose a base branch
from
Open

wip/sync: Force peers into ancestry search when blocks are not locally known #11917

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ccb7a7
sync: Force peers into ancestry search when blocks are not locally known
lexnv Apr 28, 2026
d63a47e
Update comment
lexnv Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions substrate/client/network/sync/src/strategy/chain_sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,10 +517,12 @@ where
return None;
}

// The node is continuing a known fork if either the block itself is known, the
// parent is known or the block references the previously announced `best_hash`.
let continues_known_fork =
known || known_parent || announce.header.parent_hash() == &peer.best_hash;
// The node is continuing a known fork if either the block itself is know or the
// parent is known.
//
// We cannot follow the fork by simply looking at the peer best hash, since that
// can be re-announced by the peer from a different fork entirely.
let continues_known_fork = known || known_parent;

let peer_info = is_best.then(|| {
// update their best block
Expand Down
Loading