PSM init: skip assets with mismatched decimals instead of panicking#11807
Merged
PSM init: skip assets with mismatched decimals instead of panicking#11807
Conversation
rockbmb
approved these changes
Apr 17, 2026
muharem
approved these changes
Apr 18, 2026
sigurpol
pushed a commit
that referenced
this pull request
Apr 20, 2026
…11807) Addresses issue @ggwpez raised in this comment: #11068 (comment) ## Summary Replaces the `assert!` in the PSM `InitializePsm` migration with a log + skip when an asset's decimals don't match the stable asset. Panicking in a runtime upgrade bricks the chain. Migrations must be infallible. ### Test Adds `initialize_psm_skips_assets_with_wrong_decimals` which verifies that assets with mismatched decimals are skipped while correctly-configured assets in the same migration are still added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue @ggwpez raised in this comment: #11068 (comment)
Summary
Replaces the
assert!in the PSMInitializePsmmigration with a log + skip when an asset's decimals don't match the stable asset. Panicking in a runtime upgrade bricks the chain. Migrations must be infallible.Test
Adds
initialize_psm_skips_assets_with_wrong_decimalswhich verifies that assets with mismatched decimals are skipped while correctly-configured assets in the same migration are still added.