Skip to content

[Release|CI/CD] Trigger check-sync flow in callable flows only if they are triggered manually and not with the workflow_call trigger#11631

Merged
BDevParity merged 3 commits intomasterfrom
bd-check-sync-only-on-manual-trigger
Apr 7, 2026
Merged

[Release|CI/CD] Trigger check-sync flow in callable flows only if they are triggered manually and not with the workflow_call trigger#11631
BDevParity merged 3 commits intomasterfrom
bd-check-sync-only-on-manual-trigger

Conversation

@BDevParity
Copy link
Copy Markdown
Contributor

@BDevParity BDevParity commented Apr 3, 2026

@BDevParity BDevParity requested review from a team as code owners April 3, 2026 10:37
@BDevParity BDevParity added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Apr 3, 2026
@BDevParity BDevParity enabled auto-merge April 7, 2026 09:41
@paritytech-review-bot paritytech-review-bot Bot requested a review from a team April 7, 2026 09:48
@BDevParity BDevParity added this pull request to the merge queue Apr 7, 2026
Merged via the queue into master with commit 20d65ad Apr 7, 2026
255 of 261 checks passed
@BDevParity BDevParity deleted the bd-check-sync-only-on-manual-trigger branch April 7, 2026 11:28
@EgorPopelyaev EgorPopelyaev added A4-backport-stable2506 Pull request must be backported to the stable2506 release branch A4-backport-stable2509 Pull request must be backported to the stable2509 release branch A4-backport-stable2512 Pull request must be backported to the stable2512 release branch A4-backport-stable2603 Pull request must be backported to the stable2603 release branch labels Apr 7, 2026
@paritytech-release-backport-bot
Copy link
Copy Markdown

Successfully created backport PR for stable2506:

paritytech-release-backport-bot Bot pushed a commit that referenced this pull request Apr 7, 2026
…y are triggered manually and not with the workflow_call trigger (#11631)

paritytech/release-engineering#291
(cherry picked from commit 20d65ad)
paritytech-release-backport-bot Bot pushed a commit that referenced this pull request Apr 7, 2026
…y are triggered manually and not with the workflow_call trigger (#11631)

paritytech/release-engineering#291
(cherry picked from commit 20d65ad)
@paritytech-release-backport-bot
Copy link
Copy Markdown

Successfully created backport PR for stable2509:

paritytech-release-backport-bot Bot pushed a commit that referenced this pull request Apr 7, 2026
…y are triggered manually and not with the workflow_call trigger (#11631)

paritytech/release-engineering#291
(cherry picked from commit 20d65ad)
@paritytech-release-backport-bot
Copy link
Copy Markdown

Successfully created backport PR for stable2512:

paritytech-release-backport-bot Bot pushed a commit that referenced this pull request Apr 7, 2026
…y are triggered manually and not with the workflow_call trigger (#11631)

paritytech/release-engineering#291
(cherry picked from commit 20d65ad)
@paritytech-release-backport-bot
Copy link
Copy Markdown

Successfully created backport PR for stable2603:

EgorPopelyaev pushed a commit that referenced this pull request Apr 7, 2026
Backport #11631 into `stable2506` from BDevParity.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: BDevParity <bruno.devic@parity.io>
EgorPopelyaev pushed a commit that referenced this pull request Apr 8, 2026
Backport #11631 into `stable2509` from BDevParity.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: BDevParity <bruno.devic@parity.io>
EgorPopelyaev pushed a commit that referenced this pull request Apr 13, 2026
Backport #11631 into `stable2512` from BDevParity.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: BDevParity <bruno.devic@parity.io>
EgorPopelyaev pushed a commit that referenced this pull request Apr 13, 2026
Backport #11631 into `stable2603` from BDevParity.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: BDevParity <bruno.devic@parity.io>
github-merge-queue Bot pushed a commit that referenced this pull request Apr 15, 2026
## Summary

- The combined publish workflows (`release-70`, `release-22`) call
multiple sub-workflows that each invoke `check-synchronization.yml`.
That reusable workflow has a concurrency group (`${{ github.repository
}}-${{ github.workflow }}-${{ github.ref }}`) that evaluates to the
**same value** for all callers within a single run, causing GitHub to
randomly cancel competing jobs.
- PR #11631 attempted to fix this with `github.event_name ==
'workflow_dispatch'` guards, but `github.event_name` propagates the
original trigger through `workflow_call` chains, so the guard doesn't
reliably skip the check.
- This PR replaces that guard with an explicit `skip_sync_check` boolean
input. Combined workflows pass `skip_sync_check: true` since they
already run the check at the top level. Standalone dispatches default to
`false`, preserving existing behavior.
- Also removes the redundant `check-synchronization` job from
`release-reusable-publish-packages.yml` (only ever called from workflows
that already perform the check).

Evidence: [4 consecutive failed
attempts](https://github.com/paritytech-release/polkadot-sdk/actions/runs/23787944175)
with different random jobs cancelled each time.

## Issue

- paritytech/release-engineering#291

---------

Co-authored-by: Egor_P <egor@parity.io>
paritytech-release-backport-bot Bot pushed a commit that referenced this pull request Apr 15, 2026
## Summary

- The combined publish workflows (`release-70`, `release-22`) call
multiple sub-workflows that each invoke `check-synchronization.yml`.
That reusable workflow has a concurrency group (`${{ github.repository
}}-${{ github.workflow }}-${{ github.ref }}`) that evaluates to the
**same value** for all callers within a single run, causing GitHub to
randomly cancel competing jobs.
- PR #11631 attempted to fix this with `github.event_name ==
'workflow_dispatch'` guards, but `github.event_name` propagates the
original trigger through `workflow_call` chains, so the guard doesn't
reliably skip the check.
- This PR replaces that guard with an explicit `skip_sync_check` boolean
input. Combined workflows pass `skip_sync_check: true` since they
already run the check at the top level. Standalone dispatches default to
`false`, preserving existing behavior.
- Also removes the redundant `check-synchronization` job from
`release-reusable-publish-packages.yml` (only ever called from workflows
that already perform the check).

Evidence: [4 consecutive failed
attempts](https://github.com/paritytech-release/polkadot-sdk/actions/runs/23787944175)
with different random jobs cancelled each time.

## Issue

- paritytech/release-engineering#291

---------

Co-authored-by: Egor_P <egor@parity.io>
(cherry picked from commit 9f6182f)
paritytech-release-backport-bot Bot pushed a commit that referenced this pull request Apr 15, 2026
## Summary

- The combined publish workflows (`release-70`, `release-22`) call
multiple sub-workflows that each invoke `check-synchronization.yml`.
That reusable workflow has a concurrency group (`${{ github.repository
}}-${{ github.workflow }}-${{ github.ref }}`) that evaluates to the
**same value** for all callers within a single run, causing GitHub to
randomly cancel competing jobs.
- PR #11631 attempted to fix this with `github.event_name ==
'workflow_dispatch'` guards, but `github.event_name` propagates the
original trigger through `workflow_call` chains, so the guard doesn't
reliably skip the check.
- This PR replaces that guard with an explicit `skip_sync_check` boolean
input. Combined workflows pass `skip_sync_check: true` since they
already run the check at the top level. Standalone dispatches default to
`false`, preserving existing behavior.
- Also removes the redundant `check-synchronization` job from
`release-reusable-publish-packages.yml` (only ever called from workflows
that already perform the check).

Evidence: [4 consecutive failed
attempts](https://github.com/paritytech-release/polkadot-sdk/actions/runs/23787944175)
with different random jobs cancelled each time.

## Issue

- paritytech/release-engineering#291

---------

Co-authored-by: Egor_P <egor@parity.io>
(cherry picked from commit 9f6182f)
paritytech-release-backport-bot Bot pushed a commit that referenced this pull request Apr 15, 2026
## Summary

- The combined publish workflows (`release-70`, `release-22`) call
multiple sub-workflows that each invoke `check-synchronization.yml`.
That reusable workflow has a concurrency group (`${{ github.repository
}}-${{ github.workflow }}-${{ github.ref }}`) that evaluates to the
**same value** for all callers within a single run, causing GitHub to
randomly cancel competing jobs.
- PR #11631 attempted to fix this with `github.event_name ==
'workflow_dispatch'` guards, but `github.event_name` propagates the
original trigger through `workflow_call` chains, so the guard doesn't
reliably skip the check.
- This PR replaces that guard with an explicit `skip_sync_check` boolean
input. Combined workflows pass `skip_sync_check: true` since they
already run the check at the top level. Standalone dispatches default to
`false`, preserving existing behavior.
- Also removes the redundant `check-synchronization` job from
`release-reusable-publish-packages.yml` (only ever called from workflows
that already perform the check).

Evidence: [4 consecutive failed
attempts](https://github.com/paritytech-release/polkadot-sdk/actions/runs/23787944175)
with different random jobs cancelled each time.

## Issue

- paritytech/release-engineering#291

---------

Co-authored-by: Egor_P <egor@parity.io>
(cherry picked from commit 9f6182f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A4-backport-stable2506 Pull request must be backported to the stable2506 release branch A4-backport-stable2509 Pull request must be backported to the stable2509 release branch A4-backport-stable2512 Pull request must be backported to the stable2512 release branch A4-backport-stable2603 Pull request must be backported to the stable2603 release branch R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants