collator-protocol: Enhance visibility into para id of failed to fetch collations#11629
Merged
collator-protocol: Enhance visibility into para id of failed to fetch collations#11629
Conversation
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Contributor
Author
|
/cmd prdoc --audience node_dev --bump patch |
…e_dev --bump patch'
sandreim
reviewed
Apr 3, 2026
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
lexnv
changed the title
tdimitrov
reviewed
Apr 7, 2026
tdimitrov
approved these changes
Apr 7, 2026
skunert
approved these changes
Apr 7, 2026
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
lexnv
added
A4-backport-stable2506
paritytech-release-backport-bot Bot
pushed a commit
that referenced
this pull request
Apr 7, 2026
… collations (#11629) This PR enhances the observability of our logs when validators refuse to fetch advertised collations for certain para IDs. The validator keeps track of advertised collations from collators. Then, the validator checks if it has sufficient slots (`is_slot_available`) and if the collation can be seconded (`can_second`). If either of the mentioned functions fails, the validator silently ignores the collation. This PR aims to surface this behavior and help investigate further issues. This PR is already deployed on validators and has surfaced: - #11625 Part of: - #11377 --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io> (cherry picked from commit cf245e0)
|
Successfully created backport PR for |
lexnv
added a commit
that referenced
this pull request
Apr 8, 2026
Backport #11629 into `stable2603` from lexnv. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the observability of our logs when validators refuse to fetch advertised collations for certain para IDs.
The validator keeps track of advertised collations from collators.
Then, the validator checks if it has sufficient slots (
is_slot_available) and if the collation can be seconded (can_second).If either of the mentioned functions fails, the validator silently ignores the collation.
This PR aims to surface this behavior and help investigate further issues.
This PR is already deployed on validators and has surfaced:
Part of: