Merged
Conversation
eskimor
added
T0-node
eskimor
force-pushed
the
rk-fix-paths-length
branch
from
d2fe550 to
e9ab097
Compare
Member
Author
|
ok, a little less bad than I thought in between. Skipping the loop before finding the relay parent is fine. The problem is if it is not skipped for older than expected blocks - as then slots will be seen as occupied, which should not. |
tdimitrov
approved these changes
Apr 3, 2026
eskimor
force-pushed
the
rk-fix-paths-length
branch
from
e9ab097 to
7a6f7f7
Compare
|
Successfully created backport PR for |
paritytech-release-backport-bot Bot
pushed a commit
that referenced
this pull request
Apr 3, 2026
implicit views can return paths longer than lookahead, which leads to is_slot_available skipping the loop [here](https://github.com/paritytech/polkadot-sdk/blob/a103769c2e2cb739f721d0446acabe97a2c0df08/polkadot/node/network/collator-protocol/src/validator_side/mod.rs#L1598), because of `ancestor_valid_len` being 0, leading to rejections of candidates. I also noticed that `paths_via_relay_parents` can be massively simplified, which also removes above bug. ImplicitView can likely be simplified further as I no longer see any need to keep `block_info_storage` at all anymore. Fixes: #11625 (cherry picked from commit ce07e65)
eskimor
added a commit
that referenced
this pull request
Apr 4, 2026
Backport #11626 into `stable2603` from eskimor. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: eskimor <jfanatiker@gmx.at>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implicit views can return paths longer than lookahead, which leads to is_slot_available skipping the loop here, because of
ancestor_valid_lenbeing 0, leading to rejections of candidates.I also noticed that
paths_via_relay_parentscan be massively simplified, which also removes above bug. ImplicitView can likely be simplified further as I no longer see any need to keepblock_info_storageat all anymore.Fixes: #11625