statement-store: add eviction priority ordering tests#11615
Merged
AndreiEres merged 7 commits intomasterfrom Apr 7, 2026
Merged
statement-store: add eviction priority ordering tests#11615AndreiEres merged 7 commits intomasterfrom
AndreiEres merged 7 commits intomasterfrom
Conversation
13 tasks
DenzelPenzel
added
T0-node
Contributor
|
Honestly I think this fd18545 should be enough to cover this case |
AndreiEres
reviewed
Apr 2, 2026
Address review feedback by removing three standalone eviction tests and moving the unique cross-timestamp priority assertion into the existing constraints() test. The reviewer's commit (fd18545) already added eviction ordering assertions to constraints() that cover lowest-priority-evicted-first and equal-priority rejection. The only scenario not covered was cross-timestamp dominance (a higher expiry timestamp evicts a lower one regardless of sequence number). That assertion is now added as an Account 4 section in constraints(), using far-future timestamps to avoid AlreadyExpired rejection. Removed tests: - eviction_removes_lowest_priority_first_in_order - eviction_rejects_equal_priority_statement - eviction_sequence_number_ordering_within_same_timestamp
This reverts commit e7efae4.
This reverts commit bbdab88.
AndreiEres
approved these changes
Apr 7, 2026
AndreiEres
added
the
R0-no-crate-publish-required
alexggh
approved these changes
Apr 7, 2026
Contributor
|
/cmd prdoc --audience node_dev --bump none |
…e_dev --bump none'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement unit tests for "Eviction: verify the lowest-priority statements are evicted first, corner cases of priority ordering" #11534
Summary
constraints()test with eviction priority ordering corner cases:AccountFullwhen the account is full