Skip to content

Move validate resume step after configure git#11544

Merged
BDevParity merged 3 commits intostable2603from
fix/safe-directory-failure-handler
Mar 28, 2026
Merged

Move validate resume step after configure git#11544
BDevParity merged 3 commits intostable2603from
fix/safe-directory-failure-handler

Conversation

@BDevParity
Copy link
Copy Markdown
Contributor

@BDevParity BDevParity commented Mar 27, 2026

Summary

  • Moves the "Validate resume preconditions" step after "Configure git" so that safe.directory is set before any git commands run

Context

  • Previous fix moved the step after checkout, but it still ran before safe.directory was configured, causing dubious ownership errors

@BDevParity BDevParity requested review from a team as code owners March 27, 2026 23:31
@BDevParity BDevParity force-pushed the fix/safe-directory-failure-handler branch from 9ddc3ef to 6190ccc Compare March 27, 2026 23:34
@BDevParity BDevParity enabled auto-merge (squash) March 27, 2026 23:34
@BDevParity BDevParity added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Mar 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@BDevParity BDevParity merged commit b84f4ba into stable2603 Mar 28, 2026
220 of 226 checks passed
@BDevParity BDevParity deleted the fix/safe-directory-failure-handler branch March 28, 2026 00:25
EgorPopelyaev pushed a commit that referenced this pull request Mar 31, 2026
## Summary
- Moves the "Validate resume preconditions" step after "Configure git"
so that `safe.directory` is set before any git commands run
- Uses `git branch -r` instead of `git ls-remote` since
`persist-credentials: false` prevents remote access

## Context
- Previous fix moved the step after checkout, but it still ran before
`safe.directory` was configured, causing `dubious ownership` errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants