Skip to content

Add safe.directory in failure handler#11541

Merged
BDevParity merged 3 commits intostable2603from
fix/safe-directory-failure-handler
Mar 27, 2026
Merged

Add safe.directory in failure handler#11541
BDevParity merged 3 commits intostable2603from
fix/safe-directory-failure-handler

Conversation

@BDevParity
Copy link
Copy Markdown
Contributor

@BDevParity BDevParity commented Mar 27, 2026

Summary

  • Fix resume validation in publish crates workflow by using local ref check (git branch -r) instead of git ls-remote, which fails because
    persist-credentials: false prevents remote access

Context

@BDevParity BDevParity requested review from a team as code owners March 27, 2026 18:41
@BDevParity BDevParity added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Mar 27, 2026
@BDevParity BDevParity enabled auto-merge (squash) March 27, 2026 18:45
@paritytech-review-bot paritytech-review-bot Bot requested a review from a team March 27, 2026 18:47
@github-actions
Copy link
Copy Markdown
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@BDevParity BDevParity merged commit cc9a638 into stable2603 Mar 27, 2026
220 of 227 checks passed
@BDevParity BDevParity deleted the fix/safe-directory-failure-handler branch March 27, 2026 19:30
EgorPopelyaev pushed a commit that referenced this pull request Mar 31, 2026
## Summary
- Fix resume validation in publish crates workflow by using local ref
check (`git
branch -r`) instead of `git ls-remote`, which fails because
`persist-credentials: false` prevents remote access
  ## Context                  
- Failed run:
https://github.com/paritytech-release/polkadot-sdk/actions/runs/236
  20337279/job/68797902086#step:25:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants