Skip to content

[pallet-assets-precompiles] add foreign assets instance to kitchensink #11460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xRVE merged 3 commits into from
Mar 23, 2026
Merged

[pallet-assets-precompiles] add foreign assets instance to kitchensink #11460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9867728
add foreign assets instance to kitchensink
0xRVE Mar 21, 2026
5b989d5
empty commit
0xRVE Mar 21, 2026
7c195e9
Update from github-actions[bot] running command 'prdoc --audience run…
github-actions[bot] Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions prdoc/pr_11460.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
title: '[pallet-assets-precompiles] add foreign assets instance to kitchensink'
doc:
- audience: Runtime Dev
description: |-
## Summary

- Set `CallbackHandle = (pallet_assets_precompiles::ForeignAssetId<Runtime, Instance1>,)`
in `pallet_assets::Config<Instance1>` for the kitchensink runtime.
- Asset creation (`create`, `force_create`) now automatically populates a sequential
foreign asset index mapping. Asset destruction cleans it up.

## Test plan

- [x] Run [end-to-end tests](https://github.com/paritytech/evm-test-suite/pull/142) (requires substrate-node, eth-rpc, node, cast)
- [x] Revert CallbackHandle to `()` and confirm end-to-end tests fail
crates: []
2 changes: 1 addition & 1 deletion substrate/bin/node/runtime/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1908,7 +1908,7 @@ impl pallet_assets::Config<Instance1> for Runtime {
type Holder = ();
type Freezer = ();
type Extra = ();
type CallbackHandle = ();
type CallbackHandle = (pallet_assets_precompiles::ForeignAssetId<Runtime, Instance1>,);
type WeightInfo = pallet_assets::weights::SubstrateWeight<Runtime>;
type RemoveItemsLimit = ConstU32<1000>;
#[cfg(feature = "runtime-benchmarks")]
Expand Down
Loading