Merged
Conversation
pepoviola
added
R0-no-crate-publish-required
pepoviola
changed the title
bkchr
approved these changes
Mar 23, 2026
Comment on lines
+116
to
+117
| let para_throughput: [(ParaId, Range<u32>); 4] = PARAS.map(|id| (ParaId::from(id), 2..6)); | ||
| assert_para_throughput(&relay_client, 16, para_throughput).await?; |
Member
There was a problem hiding this comment.
Suggested change
| let para_throughput: [(ParaId, Range<u32>); 4] = PARAS.map(|id| (ParaId::from(id), 2..6)); | |
| assert_para_throughput(&relay_client, 16, para_throughput).await?; | |
| assert_para_throughput(&relay_client, 16, [(ParaId::from(id), 2..6).await?; |
Contributor
Author
There was a problem hiding this comment.
Thanks for the review @bkchr, maybe I'm missing something but we need to map the paras to create the tuple (paraId, range), that why I created the para_throughput first (maybe not the best naming 🤔).
Contributor
There was a problem hiding this comment.
can we please make this assert a higher number of parablocks? 2 is quite a low number and does not give me a high confidence
Contributor
Author
There was a problem hiding this comment.
Something like 10?
Co-authored-by: Bastian Köcher <git@kchr.de>
Contributor
Author
|
/cmd fmt |
alindima
reviewed
Mar 24, 2026
alindima
reviewed
Mar 24, 2026
alindima
reviewed
Mar 24, 2026
alindima
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes to fix flaky tests.