Conversation
pepoviola
added
R0-no-crate-publish-required
17 tasks
pepoviola
changed the title
pepoviola
commented
Mar 18, 2026
|
|
||
| log::info!("Check lag - approval / dispute conclusion."); | ||
| let metric_checks: Vec<MetricCheckSetup> = vec
mchristou
reviewed
Mar 19, 2026
| ), | ||
| ( | ||
| "polkadot_parachain_candidate_dispute_concluded{validity=\"invalid\"}", | ||
| Box::new(|v| v >= 0.0), |
Contributor
There was a problem hiding this comment.
This check always passes. it should be |v| v == 0.0
sandreim
reviewed
Mar 19, 2026
| use-zombienet-sdk: false | ||
| test-filter: "misc::paritydb::paritydb_test" | ||
| runner-type: "large" | ||
| use-zombienet-sdk: true |
Contributor
There was a problem hiding this comment.
Do we still need this CI flag ?
Contributor
Author
There was a problem hiding this comment.
No, I will remove it as part of this pr.
Comment on lines
+29
to
+33
| for validator in &validator_nodes { | ||
| validator | ||
| .wait_metric_with_timeout(NODE_ROLES_METRIC, |v| v == 4.0, 60u64) | ||
| .await | ||
| .map_err(|e| anyhow!("Validator {} role check failed: {e}", validator.name()))?; |
Contributor
There was a problem hiding this comment.
Can we put this in utils? it's duplicated in many places.
lrubasze
approved these changes
Mar 23, 2026
|
|
||
| builder = PARAS.into_iter().fold(builder, |acc, para_id| { | ||
| acc.with_parachain(|p| { | ||
| let pov_size = 10000*(para_id-1999); |
Contributor
There was a problem hiding this comment.
How about adding some comments where these numbers are coming from?
pepoviola
commented
Mar 23, 2026
Contributor
Author
|
update:
cc: @sandreim |
DenzelPenzel
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate misc test: