fix: expose try-runtime feature in bridge-hub-test-utils by Kanasjnr · Pull Request #11211 · paritytech/polkadot-sdk

Kanasjnr · 2026-02-27T23:20:55Z

Description

Fixes and should probably close #10962

When running cargo test --features try-runtime (or --all-features) on BridgeHub runtimes, compilation failed with:

error[E0046]: not all trait items implemented, missing: `try_successful_origin`
  --> .../assets-common-0.27.1/src/foreign_creators.rs:29:1

This happened because bridge-hub-test-utils did not declare a try-runtime feature, so the flag never propagated to asset-test-utils → assets-common.
As a result, assets-common was compiled without try-runtime, while frame-support had it enabled → the try_successful_origin method (guarded by #[cfg(feature = "try-runtime")]) was missing, causing the trait implementation error.

Changes:

Added a try-runtime feature to bridge-hub-test-utils/Cargo.toml that forwards the flag only to the 16 dependencies that actually declare/support it.
Activated the new feature in the two test runtimes that depend on it:
- cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/Cargo.toml
- cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/Cargo.toml

After these changes, cargo check --features try-runtime and cargo test --release --locked --all-features (with SKIP_PALLET_REVIVE_FIXTURES=1) pass cleanly on both rococo and westend runtimes.

The real BridgeHub Kusama & Polkadot runtimes (in polkadot-fellows/runtimes) will need the same one-line activation in their try-runtime feature lists as seen in this error (planned as a follow-up PR).

Integration

Downstream projects / other runtimes that depend on bridge-hub-test-utils as a dev-dependency and want to use try-runtime tests should add:

try-runtime = [
    # ... existing entries ...
    "bridge-hub-test-utils/try-runtime",
    # ...
]

in their runtime Cargo.toml.
This is the same pattern already used by asset-test-utils, parachains-common, etc.

No crate publish is required this is only a feature addition in a test-utils crate.

Review Notes

The list of crates that receive try-runtime forwarding matches exactly the crates in polkadot-sdk that declare the feature (verified against your earlier table: 16 crates with, 9 without).
No new dependencies or breaking changes introduced.

Tests were verified locally with:

SKIP_PALLET_REVIVE_FIXTURES=1 cargo test -p bridge-hub-rococo-runtime --release --locked -q --all-features
SKIP_PALLET_REVIVE_FIXTURES=1 cargo test -p bridge-hub-westend-runtime --release --locked -q --all-features

→ all suites pass (some expected ERROR logs from bridge/XCM simulation tests are normal in emulated environment).

No leftover TODOs.

Checklist

My PR includes a detailed description as outlined above.
My PR follows the labeling requirements (suggest: T6-XCM, D2-trivial, I5-enhancement or similar)
I have made corresponding changes to the documentation (none needed — this is test-utils internal)
I have added / verified tests that prove my fix is effective (local test runs pass)

Bot Commands

You can use the following bot commands in comments to help manage your PR:

Labeling (Self-service for contributors):

/cmd label T1-FRAME - Add a single label
/cmd label T1-FRAME R0-no-crate-publish-required - Add multiple labels
/cmd label T6-XCM D2-substantial I5-enhancement - Add multiple labels at once
See label documentation for all available labels

Other useful commands:

/cmd fmt - Format code (cargo +nightly fmt and taplo)
/cmd prdoc - Generate PR documentation
/cmd bench - Run benchmarks
/cmd update-ui - Update UI tests
/cmd --help - Show help for all available commands

Kanasjnr · 2026-02-27T23:24:49Z

/cmd prdoc --audience node_dev --bump patch

Kanasjnr · 2026-02-27T23:30:49Z

/cmd label T6-XCM I5-enhancement R0-no-crate-publish-required

Kanasjnr · 2026-02-27T23:43:40Z

@pandres95 Kindly review

bkontur · 2026-03-03T09:00:28Z

@Kanasjnr please, apply this patch below to this branch, when somebody is using westend-emulated-chain = { workspace = true }, this should prevent unnecessary including:

westend-runtime = { workspace = true }

"westend-runtime/runtime-benchmarks",
"westend-runtime/try-runtime",

git apply a.patch

a.patch

diff --git a/cumulus/parachains/integration-tests/emulated/chains/relays/rococo/Cargo.toml b/cumulus/parachains/integration-tests/emulated/chains/relays/rococo/Cargo.toml
index 4d1d8c5841..f6263e583b 100644
--- a/cumulus/parachains/integration-tests/emulated/chains/relays/rococo/Cargo.toml
+++ b/cumulus/parachains/integration-tests/emulated/chains/relays/rococo/Cargo.toml
@@ -27,3 +27,11 @@ rococo-runtime-constants = { workspace = true }
 # Cumulus
 emulated-integration-tests-common = { workspace = true }
 parachains-common = { workspace = true, default-features = true }
+
+[features]
+runtime-benchmarks = [
+  "parachains-common/runtime-benchmarks",
+  "polkadot-primitives/runtime-benchmarks",
+  "rococo-runtime/runtime-benchmarks",
+]
+try-runtime = ["rococo-runtime/try-runtime", "parachains-common/try-runtime"]
diff --git a/cumulus/parachains/integration-tests/emulated/chains/relays/westend/Cargo.toml b/cumulus/parachains/integration-tests/emulated/chains/relays/westend/Cargo.toml
index a6e6396a38..1a421cc9da 100644
--- a/cumulus/parachains/integration-tests/emulated/chains/relays/westend/Cargo.toml
+++ b/cumulus/parachains/integration-tests/emulated/chains/relays/westend/Cargo.toml
@@ -28,3 +28,19 @@ westend-runtime-constants = { workspace = true }
 # Cumulus
 emulated-integration-tests-common = { workspace = true }
 parachains-common = { workspace = true, default-features = true }
+
+[features]
+runtime-benchmarks = [
+  "pallet-staking/runtime-benchmarks",
+  "parachains-common/runtime-benchmarks",
+  "polkadot-primitives/runtime-benchmarks",
+  "sp-runtime/runtime-benchmarks",
+  "westend-runtime-constants/runtime-benchmarks",
+  "westend-runtime/runtime-benchmarks",
+]
+try-runtime = [
+  "pallet-staking/try-runtime",
+  "westend-runtime/try-runtime",
+  "parachains-common/try-runtime",
+  "sp-runtime/try-runtime",
+]

github-actions · 2026-03-03T22:14:06Z

Review required! Latest push from author must always be reviewed

Kanasjnr · 2026-03-03T22:14:55Z

@Kanasjnr please, apply this patch below to this branch, when somebody is using westend-emulated-chain = { workspace = true }, this should prevent unnecessary including:

westend-runtime = { workspace = true }

"westend-runtime/runtime-benchmarks",
"westend-runtime/try-runtime",

git apply a.patch

a.patch

diff --git a/cumulus/parachains/integration-tests/emulated/chains/relays/rococo/Cargo.toml b/cumulus/parachains/integration-tests/emulated/chains/relays/rococo/Cargo.toml
index 4d1d8c5841..f6263e583b 100644
--- a/cumulus/parachains/integration-tests/emulated/chains/relays/rococo/Cargo.toml
+++ b/cumulus/parachains/integration-tests/emulated/chains/relays/rococo/Cargo.toml
@@ -27,3 +27,11 @@ rococo-runtime-constants = { workspace = true }
 # Cumulus
 emulated-integration-tests-common = { workspace = true }
 parachains-common = { workspace = true, default-features = true }
+
+[features]
+runtime-benchmarks = [
+  "parachains-common/runtime-benchmarks",
+  "polkadot-primitives/runtime-benchmarks",
+  "rococo-runtime/runtime-benchmarks",
+]
+try-runtime = ["rococo-runtime/try-runtime", "parachains-common/try-runtime"]
diff --git a/cumulus/parachains/integration-tests/emulated/chains/relays/westend/Cargo.toml b/cumulus/parachains/integration-tests/emulated/chains/relays/westend/Cargo.toml
index a6e6396a38..1a421cc9da 100644
--- a/cumulus/parachains/integration-tests/emulated/chains/relays/westend/Cargo.toml
+++ b/cumulus/parachains/integration-tests/emulated/chains/relays/westend/Cargo.toml
@@ -28,3 +28,19 @@ westend-runtime-constants = { workspace = true }
 # Cumulus
 emulated-integration-tests-common = { workspace = true }
 parachains-common = { workspace = true, default-features = true }
+
+[features]
+runtime-benchmarks = [
+  "pallet-staking/runtime-benchmarks",
+  "parachains-common/runtime-benchmarks",
+  "polkadot-primitives/runtime-benchmarks",
+  "sp-runtime/runtime-benchmarks",
+  "westend-runtime-constants/runtime-benchmarks",
+  "westend-runtime/runtime-benchmarks",
+]
+try-runtime = [
+  "pallet-staking/try-runtime",
+  "westend-runtime/try-runtime",
+  "parachains-common/try-runtime",
+  "sp-runtime/try-runtime",
+]

updated

Kanasjnr · 2026-03-05T14:01:59Z

@bkontur @pandres95 @rockbmb Pinging you on this kindly help review

…ly set keys (paritytech#11197) Tracks whether session keys were set externally (via `SessionInterface`, e.g. from AH) or locally. Transitions between the two paths correctly manage the key deposit and consumer ref in both directions. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…e_dev --bump patch'

…1223) Fix failing semver check due to old compiled-in cargo in parity-publish by: 1. Upgrading `parity-publish` to the latest version. 2. Fixing its build dependencies installation with `apt-get`. ``` Error: failed to load manifest for workspace member `/__w/polkadot-sdk/polkadot-sdk/bridges/bin/runtime-common` referenced by workspace at `/__w/polkadot-sdk/polkadot-sdk/Cargo.toml` Caused by: 0: failed to load manifest for dependency `bp-header-chain` ... 23: failed to load manifest for dependency `pallet-revive` 24: failed to parse manifest at `/__w/polkadot-sdk/polkadot-sdk/substrate/frame/revive/Cargo.toml` 25: feature `edition2024` is required The package requires the Cargo feature called `edition2024`, but that feature is not stabilized in this version of Cargo (1.83.0). Consider adding `cargo-features = ["edition2024"]` to the top of Cargo.toml (above the [package] table) to tell Cargo you are opting in to use this unstable feature. ```

This PR brings litep2p [v0.13.1](https://github.com/paritytech/litep2p/releases/tag/v0.13.1) to polkadot-sdk. The improvements include: 1. When dialing remote peers, all addresses from the DHT are tried, starting from the public addresses. Before litep2p v0.13.1, only up to 8 addresses were tried, leading to dial failures when due to misconfiguration there was a lot of private addresses in the DHT. 2. Protocols are now notified about connected peers before the library user, fixing failures in opening substreams when the user command arrived before the connection event. 3. Ping protocol implementation now conforms to the spec. This improves the connection stability between polkadot-sdk and [smoldot](https://github.com/smol-dot/smoldot) dramatically. Before this PR, smoldot always disconnected polkadot-sdk peers every 15 seconds for 5 seconds due to failed pings. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Closes: paritytech#11205 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Lukasz Rubaszewski <117115317+lrubasze@users.noreply.github.com>

This is fix for failing job: https://github.com/paritytech/polkadot-sdk/actions/runs/22578558700/job/65404381763?pr=10215 <img width="2079" height="544" alt="image" src="https://github.com/user-attachments/assets/37d07015-fa22-4079-ab3f-8315dcf1565c" /> Inspired by: paritytech#11223

… for emulated chains

…rella regeneration)

Kanasjnr · 2026-03-20T12:13:04Z

@bkontur @rockbmb @pandres95 Pinging you on this again the pr is ready for review

Kanasjnr · 2026-03-30T14:43:49Z

@bkontur @rockbmb a gentle reminder this pr needs review thanks

Drop prdoc entries for other PRs (paritytech#11197, paritytech#11204, paritytech#11224) that were accidentally included on this branch.

Required by check-zepter and check-umbrella after master added pallet-accumulate-and-forward and pallet-dap to emulated tests common.

franciscoaguirre

👍

fix: expose try-runtime feature in bridge-hub-test-utils

f3c82b6

paritytech-cmd-bot-polkadot-sdk Bot added I5-enhancement An additional feature request. R0-no-crate-publish-required The change does not require any crates to be re-published. T6-XCM This PR/Issue is related to XCM. labels Feb 27, 2026

rockbmb requested changes Feb 28, 2026

View reviewed changes

Comment thread prdoc/pr_11211.prdoc Outdated

Kanasjnr requested a review from rockbmb February 28, 2026 00:23

pandres95 approved these changes Mar 2, 2026

View reviewed changes

github-actions Bot requested a review from pandres95 March 3, 2026 22:14

sigurpol and others added 10 commits March 8, 2026 21:19

Update from github-actions[bot] running command 'prdoc --audience nod…

2e9b3f5

…e_dev --bump patch'

chore: polished prdoc

6e071ad

chore:prdoc updated

5e772dc

Apply relay optimization patch and fix transitive feature propagation…

ceef81f

… for emulated chains

chore: fix CI failures (TOML formatting, feature propagation, and umb…

748488e

…rella regeneration)

Kanasjnr force-pushed the Kanas/fix-bridge-hub-test-utils-try-runtime branch from c224a5f to 748488e Compare March 8, 2026 22:04

Kanasjnr requested review from a team as code owners March 8, 2026 22:04

paritytech-review-bot Bot requested a review from a team March 8, 2026 22:04

pgherveou removed this from [preview] release tracker Mar 19, 2026

pandres95 approved these changes Mar 23, 2026

View reviewed changes

franciscoaguirre reviewed Apr 9, 2026

View reviewed changes

Comment thread prdoc/pr_11211.prdoc Outdated

Kanasjnr requested a review from franciscoaguirre April 10, 2026 15:56

Kanasjnr force-pushed the Kanas/fix-bridge-hub-test-utils-try-runtime branch from 08bc7ea to 3c045a6 Compare April 10, 2026 21:38

fix: prdoc formatting for pr_11211

c48cb69

Kanasjnr force-pushed the Kanas/fix-bridge-hub-test-utils-try-runtime branch from 3c045a6 to c48cb69 Compare April 10, 2026 21:52

fix: correctly quote prdoc title and fix formatting

1cd8796

Kanasjnr force-pushed the Kanas/fix-bridge-hub-test-utils-try-runtime branch from a06a974 to 1cd8796 Compare April 10, 2026 22:07

Merge branch 'master' into Kanas/fix-bridge-hub-test-utils-try-runtime

885f77a

rockbmb requested changes Apr 15, 2026

View reviewed changes

Comment thread prdoc/pr_11224.prdoc Outdated

Comment thread prdoc/pr_11211.prdoc

Kanasjnr requested a review from rockbmb April 21, 2026 07:23

ggwpez reviewed May 20, 2026

View reviewed changes

Comment thread prdoc/pr_11204.prdoc Outdated

chore: remove unrelated prdoc files from paritytech#11211

78106e4

Drop prdoc entries for other PRs (paritytech#11197, paritytech#11204, paritytech#11224) that were accidentally included on this branch.

Kanasjnr requested a review from ggwpez May 20, 2026 21:00

Kanasjnr added 2 commits May 20, 2026 22:08

Merge branch 'master' into Kanas/fix-bridge-hub-test-utils-try-runtime

bf5a9bc

fix: propagate try-runtime and runtime-benchmarks for DAP pallets

f4df272

Required by check-zepter and check-umbrella after master added pallet-accumulate-and-forward and pallet-dap to emulated tests common.

ggwpez approved these changes May 22, 2026

View reviewed changes

Merge branch 'master' into Kanas/fix-bridge-hub-test-utils-try-runtime

2c69ee3

franciscoaguirre approved these changes May 22, 2026

View reviewed changes

bkontur approved these changes May 25, 2026

View reviewed changes

Merge branch 'master' into Kanas/fix-bridge-hub-test-utils-try-runtime

19b9291

bkontur enabled auto-merge May 25, 2026 09:29

Kanasjnr added 3 commits May 25, 2026 13:59

Merge branch 'master' into Kanas/fix-bridge-hub-test-utils-try-runtime

f9c0d8f

Merge branch 'master' into Kanas/fix-bridge-hub-test-utils-try-runtime

bf1b60f

Merge branch 'master' into Kanas/fix-bridge-hub-test-utils-try-runtime

299c5c5

rockbmb approved these changes May 26, 2026

View reviewed changes

Merge branch 'master' into Kanas/fix-bridge-hub-test-utils-try-runtime

ea26af6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: expose try-runtime feature in bridge-hub-test-utils#11211

fix: expose try-runtime feature in bridge-hub-test-utils#11211
Kanasjnr wants to merge 23 commits into
paritytech:masterfrom
Kanasjnr:Kanas/fix-bridge-hub-test-utils-try-runtime

Kanasjnr commented Feb 27, 2026 •

edited

Loading

Uh oh!

Kanasjnr commented Feb 27, 2026

Uh oh!

Kanasjnr commented Feb 27, 2026

Uh oh!

Kanasjnr commented Feb 27, 2026

Uh oh!

Uh oh!

bkontur commented Mar 3, 2026

Uh oh!

github-actions Bot commented Mar 3, 2026

Uh oh!

Kanasjnr commented Mar 3, 2026

Uh oh!

Kanasjnr commented Mar 5, 2026

Uh oh!

Kanasjnr commented Mar 20, 2026

Uh oh!

Kanasjnr commented Mar 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

franciscoaguirre left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Conversation

Kanasjnr commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Integration

Review Notes

Checklist

Bot Commands

Uh oh!

Kanasjnr commented Feb 27, 2026

Uh oh!

Kanasjnr commented Feb 27, 2026

Uh oh!

Kanasjnr commented Feb 27, 2026

Uh oh!

Uh oh!

bkontur commented Mar 3, 2026

Uh oh!

github-actions Bot commented Mar 3, 2026

Uh oh!

Kanasjnr commented Mar 3, 2026

Uh oh!

Kanasjnr commented Mar 5, 2026

Uh oh!

Kanasjnr commented Mar 20, 2026

Uh oh!

Kanasjnr commented Mar 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

franciscoaguirre left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Kanasjnr commented Feb 27, 2026 •

edited

Loading