statement-store: fix benchmark EMFILE by pooling RPC connections#11070
Merged
DenzelPenzel merged 2 commits intomasterfrom Feb 20, 2026
Merged
statement-store: fix benchmark EMFILE by pooling RPC connections#11070DenzelPenzel merged 2 commits intomasterfrom
DenzelPenzel merged 2 commits intomasterfrom
Conversation
DenzelPenzel
added
the
R0-no-crate-publish-required
DenzelPenzel
force-pushed
the
denzelpenzel/statement-store-fix-bench
branch
2 times, most recently
from
f474f39 to
210c2d0
Compare
Contributor
|
Do we have the same problem in the latency bench? Or only one_node/many_nodes benches? |
Contributor
Author
Actually I found this issue for the all bench tests |
alexggh
approved these changes
Feb 17, 2026
DenzelPenzel
force-pushed
the
denzelpenzel/statement-store-fix-bench
branch
2 times, most recently
from
b417255 to
895d5dc
Compare
AndreiEres
approved these changes
Feb 19, 2026
| info!(""); | ||
|
|
||
| let mut rpc_clients = Vec::new(); | ||
| let mut rpc_pools: Vec<Vec<RpcClient>> = Vec::new(); |
Contributor
There was a problem hiding this comment.
Please check that running a test with 1000 submitters we don't create 10_000*nodes rpc clients
DenzelPenzel
force-pushed
the
denzelpenzel/statement-store-fix-bench
branch
from
895d5dc to
0fc865d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Root Cause
Each of ~50,000 benchmark participants called
node.rpc().await?to create its ownTCP/WebSocket connection, exhausting the OS per-process file descriptor limit (EMFILE error 24)
Fix
Introduce
RPC_POOL_SIZE = 100constant. Create a pool of conn per node, thendistribute them round-robin to participants reduces tot file descriptors from ~50,000 to at most 600 (6 nodes x 100)
Test plan
statement_store_many_nodes_benchwith zombienet to verify no EMFILE error