pallet-revive: minor cleanups and fixes#11054
Merged
Conversation
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump patch |
2 similar comments
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump patch |
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump patch |
Contributor
|
Command "prdoc --audience runtime_dev --bump patch" has failed ❌! See logs here |
Contributor
|
Command "prdoc --audience runtime_dev --bump patch" has failed ❌! See logs here |
pgherveou
added
the
T7-smart_contracts
xermicus
approved these changes
Feb 13, 2026
Change Counter.sol and NestedCounter.sol fields from uint256 to uint64. This changes the Solidity storage packing layout (uint64 + address fit in a single slot). Update prestate_diff_mode_tracing_works test accordingly.
Remove the k256 dependency from pallet-revive. Migrate benchmark signing helpers (create_test_signer, create_signed_transaction, setup_finalize_block_benchmark) to use sp_core::ecdsa::Pair instead of k256::ecdsa::SigningKey.
Fix indentation of closure body in call.rs and remove stray blank line in lib.rs.
Remove incorrect gas_price field from the decoder (index 4) which was not present in the encoder, and shift subsequent field indices down. Add ..Default::default() for any remaining fields. This aligns the decoder with the encoder and the EIP-7702 specification.
Upgrade pallet-revive and pallet-revive-eth-rpc to edition = "2024". Key changes: - Remove unnecessary `ref` in match patterns (match ergonomics v2) - Use if-let chains to flatten nested conditionals - Reformat imports per Rust 2024 style (cargo +nightly fmt)
pgherveou
force-pushed
the
pg/revive-cleanup
branch
from
e5fbc52 to
490aa77
Compare
Contributor
Author
|
oups claude forced push for me, fixed my config so it merge and update next time |
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump patch |
Contributor
|
In the future could you split this up into two PRs:
|
…time_dev --bump patch'
0xRVE
requested changes
Feb 13, 2026
0xRVE
reviewed
Feb 13, 2026
0xRVE
reviewed
Feb 13, 2026
0xRVE
approved these changes
Feb 13, 2026
| target: LOG_TARGET, | ||
| "eth_transact substrate tx hash: 0x{}", | ||
| sp_core::hexdisplay::HexDisplay::from(&sp_core::hashing::blake2_256(&self.encode())), | ||
| ); |
Contributor
There was a problem hiding this comment.
I think this can be quite spammy so maybe should be trace in stead of debug?
pgherveou
commented
Feb 13, 2026
EgorPopelyaev
approved these changes
Feb 13, 2026
marian-radu
approved these changes
Feb 13, 2026
…10.9 The Cargo.lock had a mass dependency update that bumped curl-sys (needs OpenSSL 3.0+), slotmap (deprecated HopSlotMap), assert_cmd (deprecated cargo_bin), and schemars (dual versions breaking staging-xcm JsonSchema). Reset to master's lockfile with only necessary changes. Also bump parity-publish from 0.10.6 to 0.10.9 in all CI workflows. The old version embeds Cargo 1.83.0 which doesn't support edition 2024, while 0.10.9 uses Cargo 0.94.0 (Rust 1.87+) which does.
parity-publish 0.10.9 requires Rust 1.90+, but CI uses Rust 1.88.0. Revert to 0.10.6 which is compatible with Rust 1.88. Fixes failing check-publish, check-publish-compile, and check-semver jobs.
The pallet-revive and pallet-revive-eth-rpc crates use edition = "2024" which requires the unstable edition2024 cargo feature. Add cargo-features = ["edition2024"] to enable this feature.
The removal of the incorrect gas_price field from Transaction7702Unsigned is technically a breaking API change, but it's a bug fix for a non-functional field that was incorrectly present in the decoder. Override semver validation for this pre-1.0 crate.
Edition 2024 became stable in Rust 1.85.0, and the CI uses Rust 1.88.0, so the cargo-features declaration is no longer needed.
This reverts the previous commit. The cargo-features declaration is still needed because Cargo 1.83.0 (used in CI) requires it for edition 2024.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preparatory cleanup PR extracted from the EIP-7702 branch to simplify review.
uint256touint64in Counter/NestedCounter fixtures, to avoid U256 conversion in tests.eth_transactsubstrate tx hashTransaction7702Signeddecoder field order (removed incorrectgas_pricefield at index 4, aligned with encoder)