Consolidate pallet-assets metadata benchmarks into single get_metadata benchmark#11037
Merged
Consolidate pallet-assets metadata benchmarks into single get_metadata benchmark#11037
Conversation
Contributor
Author
|
/cmd bench --runtime dev |
Contributor
|
Command "bench --runtime dev" has started 🚀 See logs here |
Contributor
Author
|
/cmd bench --runtime dev --pallet pallet_assets pallet-assets-precompiles |
Contributor
|
Command "bench --runtime dev --pallet pallet_assets pallet-assets-precompiles" has started 🚀 See logs here |
Contributor
|
Command "bench --runtime dev --pallet pallet_assets pallet-assets-precompiles" has failed ❌! See logs here |
Contributor
Author
|
/cmd bench --runtime dev --pallet pallet_assets pallet_assets_precompiles |
Contributor
|
Command "bench --runtime dev --pallet pallet_assets pallet_assets_precompiles" has started 🚀 See logs here |
Contributor
|
Command "bench --runtime dev --pallet pallet_assets pallet_assets_precompiles" has failed ❌! See logs here |
Contributor
Author
|
/cmd bench --runtime dev --pallet pallet_assets |
Contributor
|
Command "bench --runtime dev --pallet pallet_assets" has started 🚀 See logs here |
…--pallet pallet_assets'
Contributor
|
Command "bench --runtime dev --pallet pallet_assets" has finished ✅ See logs here DetailsSubweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
Contributor
Author
|
/cmd bench --runtime dev --pallet pallet_assets_precompiles |
Contributor
|
Command "bench --runtime dev --pallet pallet_assets_precompiles" has started 🚀 See logs here |
Contributor
|
Command "bench --runtime dev --pallet pallet_assets_precompiles" has failed ❌! See logs here |
Contributor
Author
|
/cmd bench --runtime asset-hub-westend --pallet pallet_assets |
Contributor
Author
|
/cmd bench --runtime asset-hub-rococo --pallet pallet_assets |
Contributor
|
Command "bench --runtime asset-hub-westend --pallet pallet_assets" has started 🚀 See logs here |
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump patch |
Contributor
|
Command "bench --runtime asset-hub-rococo --pallet pallet_assets" has started 🚀 See logs here |
…time_dev --bump patch'
Contributor
|
Command "bench --runtime asset-hub-rococo --pallet pallet_assets" has failed ❌! See logs here |
…t-hub-westend --pallet pallet_assets'
Contributor
|
Command "bench --runtime asset-hub-westend --pallet pallet_assets" has finished ✅ See logs here DetailsSubweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
…dot-sdk into rve/ierc20metadata
pgherveou
approved these changes
Feb 13, 2026
xermicus
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the three identical
get_name,get_symbol, andget_decimalsbenchmarks into a singleget_metadatabenchmark. This addresses the follow-up from #10971 where it was noted that these benchmarks perform the same operation (Pallet::get_metadata()).Changes
Benchmarks
substrate/frame/assets/src/benchmarking.rsget_name,get_symbol,get_decimalswith singleget_metadatabenchmarkWeight Functions
substrate/frame/assets/src/weights.rsget_name(),get_symbol(),get_decimals()with singleget_metadata()inWeightInfotraitSubstrateWeight<T>and()Precompile
substrate/frame/assets/precompiles/src/lib.rsname(),symbol(), anddecimals()methods to all chargeget_metadata()weightCumulus Runtimes
Updated weight implementations in:
asset-hub-rococo:pallet_assets_foreign.rs,pallet_assets_local.rs,pallet_assets_pool.rsasset-hub-westend:pallet_assets_foreign.rs,pallet_assets_local.rs,pallet_assets_pool.rsRationale
All three original benchmarks were measuring the exact same operation - a single metadata storage read. Consolidating them:
WeightInfotraitname(),symbol(), anddecimals()have identical costsCloses follow-up from #10971 (comment)