[FRAME] Omni bencher run each benchmark at least 10 secs#10794
Merged
[FRAME] Omni bencher run each benchmark at least 10 secs#10794
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
commented
Jan 19, 2026
| &mut Default::default(), | ||
| &executor, | ||
| "Benchmark_dispatch_benchmark", | ||
| ¶ms(false, 1), |
Member
Author
There was a problem hiding this comment.
I reduced this to 1 since DB tracking should not need repetition.
Member
Author
|
/cmd bench --pallet pallet_staking_async --runtime asset-hub-westend |
Contributor
|
Command "bench --pallet pallet_staking_async --runtime asset-hub-westend" has started 🚀 See logs here |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Member
Author
|
/cmd bench --pallet pallet_staking_async --runtime asset-hub-westend |
Contributor
|
Command "bench --pallet pallet_staking_async --runtime asset-hub-westend" has started 🚀 See logs here |
…t_staking_async --runtime asset-hub-westend'
Contributor
|
Command "bench --pallet pallet_staking_async --runtime asset-hub-westend" has finished ✅ See logs here DetailsSubweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
bkchr
reviewed
Jan 19, 2026
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
What do you want to achieve with this PR? Why are you not calling the actual benchmark in a tight loop?
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Member
Author
|
/cmd bench --pallet pallet_staking_async --runtime asset-hub-westend |
Contributor
|
Command "bench --pallet pallet_staking_async --runtime asset-hub-westend" has started 🚀 See logs here |
Member
Author
We select the values for the components outside of the Runtime, here. The runtime then gets these component values via |
…t_staking_async --runtime asset-hub-westend'
Contributor
|
Command "bench --pallet pallet_staking_async --runtime asset-hub-westend" has finished ✅ See logs here DetailsSubweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
bkchr
approved these changes
Jan 28, 2026
sigurpol
approved these changes
Feb 4, 2026
ggwpez
added
the
A4-backport-stable2512
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
sigurpol
approved these changes
Feb 9, 2026
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-10794-to-stable2512
git worktree add --checkout .worktree/backport-10794-to-stable2512 backport-10794-to-stable2512
cd .worktree/backport-10794-to-stable2512
git reset --hard HEAD^
git cherry-pick -x 822c6f6f574e5d35e005d24757241300b458ed81
git push --force-with-lease |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
--min-duration <s>Example of the System benchmark with the
set_heap_pagesbenchmark that took less than 10 ms before:Now takes 10 seconds: