[Penpal] cleanup XCM config setup regarding assets by clangenb · Pull Request #10726 · paritytech/polkadot-sdk

clangenb · 2026-01-05T16:08:32Z

Closes #7314 by implementing all the subtasks mentioned in #7314 (comment).

Changes

Essentially, the main driver of all changes is that we adjust the Penpal runtime as follows:

Make the native token the base token for buying weight (before it was a hybrid set up, probably not 100% intentional).
Merge the Assets and the ForeignAssets pallet into one pallet called Assets, as the local assets can also be identified with a location starting with parents: 0.
Give the pallet-asset-conversion a genesis config so that we can easily set up pools at genesis instead of redundantly calling the setup macro with the same args.

Test Changes

I tried to keep the changes minimal in the tests in order to not harm any previously established invariants. Hence, in most cases I just did:

Add a PEN<>WND pool in order to be able to pay xcm execution fees in WND
Replaced the Penpal's teleportable asset with it's new location based version.
In very few cases, I switched from WND to PEN to make the tests easier, when I was sure that no invariants would be harmed.
The rest should only be renamings.

…_tx_payment

…eeCharger

…Relaychain

…create_pool_with_wnd_on`

… currency

…_local_account

…_different_local_account

…s/assets/asset-hub-rococo/src/genesis.rs Co-authored-by: Adrian Catangiu <adrian@parity.io>

…et-hub-westend/src/tests/xcm_fee_estimation.rs Co-authored-by: Adrian Catangiu <adrian@parity.io>

…rsion and use it for genesis setup.

clangenb · 2026-03-24T08:37:44Z

/cmd prdoc --audience runtime_dev --bump minor

github-actions · 2026-03-24T08:39:44Z

Command "prdoc --audience runtime_dev --bump minor" has failed ❌! See logs here

clangenb · 2026-03-24T08:40:26Z

/cmd prdoc --audience runtime_dev --bump minor --force

…time_dev --bump minor --force'

franciscoaguirre · 2026-03-25T18:26:03Z

-		let asset_id_for_delivery_fees = VersionedAssetId::from(Location::parent());
+		let asset_id_for_delivery_fees = VersionedAssetId::from(Location::here());


This is controlled by the router configured in the executor

franciscoaguirre · 2026-03-25T18:31:32Z

The asset for delivery fees is defined in PriceForSiblingParachainDelivery and PriceForParentDelivery. They both use FeeAssetId which is set as Location::here() so they are using the penpal native asset

Thank you very much, I understand now. 👍

is there anything to do here? unclear

Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>

clangenb · 2026-03-26T06:46:00Z

Thanks for the reviews guys! I guess we can add this to the merge queue? 😄 🚀

This reverts commit e8ad708.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

@0xRVE

Integrates SDK release 2604. ## Contracts - [x] @0xRVE — [#11460](paritytech/polkadot-sdk#11460) `CallbackHandle` check - [x] @0xRVE — [#11590](paritytech/polkadot-sdk#11590) Asset-conversion precompile · [4759eb9](4759eb9) - [x] @pgherveou — [#11416](paritytech/polkadot-sdk#11416) Auto-mapping (`AutoMap`) · [6dd3ddc](6dd3ddc) #1165 - [x] @mokita-j — [#11507](paritytech/polkadot-sdk#11507) Revive debug enable ## Bridges - [x] @acatangiu — [#11694](paritytech/polkadot-sdk#11694) `pallet_xcm_bridge_hub_router` `UnpaidExport` flag · [635ac29](635ac29) - [x] @yrong — [#11354](paritytech/polkadot-sdk#11354) Snowbridge inbound nonce API · [c6fa9f2](c6fa9f2) ## Async backing / collator - [x] @sandreim — [#11778](paritytech/polkadot-sdk#11778) Relay-parent offset ## Account recovery - [x] @ggwpez — [#10482](paritytech/polkadot-sdk#10482) pallet-recovery modernization (HoldConsideration follow-up + re-bench) · [7401ea9](7401ea9) ## Penpal / integration tests - [x] @clangenb — [#10726](paritytech/polkadot-sdk#10726) Penpal merged `Assets`/`ForeignAssets` (downstream fixups) · [3a8aa42](3a8aa42) - [x] @clangenb — Encointer pallet integration 2604: Revert this afterwards c944b09 ## General - [ ] Re-benchmark weights #1163 - [x] Check for in-code TODOs - [x] Check for all migrations --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Signed-off-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com> Co-authored-by: clangenb <37865735+clangenb@users.noreply.github.com> Co-authored-by: Christian Langenbacher <clangenb@pm.me> Co-authored-by: Monica Jin <monicachenjin@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Andrei Trandafir <142614787+andreitrand@users.noreply.github.com> Co-authored-by: Christian Langenbacher <clangenb+gh@protonmail.ch> Co-authored-by: Paolo La Camera <paolo@parity.io> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: GitHub Action <action@github.com>

clangenb added 5 commits January 5, 2026 16:31

[penpal] remove local Assets instance, and introduce asset_conversion…

8971603

…_tx_payment

[penpal] remove unused ForeignAssetFeeAsExistentialDepositMultiplierF…

b0c0156

…eeCharger

[penpal] add more tokens to genesis config

5e4c4d6

fmt

075af24

improve MaybeResolveAssetTo implementation

1438b3b

clangenb requested a review from a team as a code owner January 5, 2026 16:08

clangenb mentioned this pull request Jan 5, 2026

Penpal xcm configuration cleanup #7314

Closed

clangenb marked this pull request as draft January 5, 2026 16:09

clangenb added 22 commits January 5, 2026 22:48

[penpal] don't redundantly define relaychain location

53fd49a

deprecate AssetsToBlockAuthor and move BlockAuthor to parachains-common

0609bbe

Make penpal-emulated-chain compile

9aba028

move Pen2 to Xcm config and fmt presets

65b8db9

add comment

f67ce57

[penpal] correctly use Location::here for native currency instead of …

529ceb9

…Relaychain

[penpal] disallow plain payment in relay tokens

67cdc5a

[penpal] remove unused imports

417ac93

[integration-tests] split of create_foreign_pool_with_wnd_on from `…

63f6ae7

…create_pool_with_wnd_on`

[penpal-runtime] disambiguate pallet assets it

ac941e9

Replace local teleportable with Penpal Native currency

758df2e

fix pool creation

abefde1

[penpal] fix SwapFirstAssetTrader: trade into Native instead of Relay…

7e6c5bb

… currency

[integration-tests] fix hybrid_transfer_test

272763a

[penpal] fix sending xcm paying fees in foreign assets

260bb78

[penpal] fix transact_from_para_to_para_through_asset_hub test

d7046b1

[integration-tests] fix exchange asset integration test

3945041

[integration-tests] fmt

c1666c6

[integration-tests] fix account_on_sibling_syschain_aliases_into_same…

c5e3e1a

…_local_account

[integration-tests] fix account_on_sibling_syschain_cannot_alias_into…

f9f91e5

…_different_local_account

[integration-tests] fix authorized_cross_chain_aliases

51af1f0

[integration-tests] fix local asset swap test

c1c50f6

clangenb and others added 4 commits March 24, 2026 07:21

Update cumulus/parachains/integration-tests/emulated/chains/parachain…

023a7fa

…s/assets/asset-hub-rococo/src/genesis.rs Co-authored-by: Adrian Catangiu <adrian@parity.io>

Update cumulus/parachains/integration-tests/emulated/tests/assets/ass…

77f1ef8

…et-hub-westend/src/tests/xcm_fee_estimation.rs Co-authored-by: Adrian Catangiu <adrian@parity.io>

[pallet-asset-conversion] add pool setup method to pallet-asset-conve…

81575ac

…rsion and use it for genesis setup.

Merge branch 'master' into cl/penpal-xcm-config

10f5fb2

clangenb commented Mar 24, 2026

View reviewed changes

Comment thread cumulus/parachains/integration-tests/emulated/common/src/macros.rs Outdated

github-actions Bot and others added 5 commits March 24, 2026 08:42

Update from github-actions[bot] running command 'prdoc --audience run…

2f55632

…time_dev --bump minor --force'

derive serde always

f788c87

fmt

6b675c0

fix test

58daa1d

manual fix of PRDOC

0e5e64c

clangenb mentioned this pull request Mar 24, 2026

[xcm-emulator] dry-run has side-effects in process_messages() #11486

Open

clangenb and others added 2 commits March 24, 2026 23:15

reference follow-up issue

8d1bb09

Merge branch 'master' into cl/penpal-xcm-config

c2e2ea1

acatangiu approved these changes Mar 25, 2026

View reviewed changes

franciscoaguirre approved these changes Mar 25, 2026

View reviewed changes

clangenb and others added 2 commits March 25, 2026 22:44

Apply suggestion from @franciscoaguirre

03bf2ad

Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>

Merge branch 'master' into cl/penpal-xcm-config

53d3dca

acatangiu added this pull request to the merge queue Mar 26, 2026

Merged via the queue into paritytech:master with commit e8ad708 Mar 26, 2026
250 of 251 checks passed

pepoviola added a commit that referenced this pull request Mar 27, 2026

Revert "[Penpal] cleanup XCM config setup regarding assets (#10726)"

89cfd8f

This reverts commit e8ad708.

pepoviola mentioned this pull request Mar 30, 2026

penpal build-spec fails with ForeignAssets #11558

Closed

clangenb mentioned this pull request Mar 31, 2026

[testing] update emulated tests involving Penpal polkadot-fellows/runtimes#1125

Closed

ggwpez added a commit to polkadot-fellows/runtimes that referenced this pull request May 4, 2026

Integrate paritytech/polkadot-sdk#10726

3a8aa42

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez mentioned this pull request May 4, 2026

Integrate SDK 2604 polkadot-fellows/runtimes#1159

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Penpal] cleanup XCM config setup regarding assets#10726

[Penpal] cleanup XCM config setup regarding assets#10726
acatangiu merged 150 commits into
paritytech:masterfrom
clangenb:cl/penpal-xcm-config

clangenb commented Jan 5, 2026 •

edited

Loading

Uh oh!

clangenb commented Mar 24, 2026

Uh oh!

Uh oh!

github-actions Bot commented Mar 24, 2026

Uh oh!

clangenb commented Mar 24, 2026

Uh oh!

franciscoaguirre Mar 25, 2026

Uh oh!

franciscoaguirre Mar 25, 2026

Uh oh!

clangenb Mar 25, 2026

Uh oh!

acatangiu Mar 26, 2026

Uh oh!

Uh oh!

clangenb commented Mar 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		let asset_id_for_delivery_fees = VersionedAssetId::from(Location::parent());
		let asset_id_for_delivery_fees = VersionedAssetId::from(Location::here());

Conversation

clangenb commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Test Changes

Uh oh!

clangenb commented Mar 24, 2026

Uh oh!

Uh oh!

github-actions Bot commented Mar 24, 2026

Uh oh!

clangenb commented Mar 24, 2026

Uh oh!

franciscoaguirre Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

franciscoaguirre Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

clangenb Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

acatangiu Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

clangenb commented Mar 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

clangenb commented Jan 5, 2026 •

edited

Loading