Skip to content

[stable2512] Backport #10680 #10684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
paritytech-release-backport-bot wants to merge 1 commit into from
Closed

[stable2512] Backport #10680 #10684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions prdoc/pr_10680.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
title: 'revive: fix revive post_upgrade assert'
doc:
- audience: Runtime Dev
description: Fix post_upgrade assertion logic in revive v2 migration
crates:
- name: pallet-revive
bump: patch
4 changes: 2 additions & 2 deletions substrate/frame/revive/src/migrations/v2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,10 @@ impl<T: Config> SteppedMigration for Migration<T> {
"Migration failed: the number of items in the storage after the migration is not the same as before"
);

let deposit_sum: crate::BalanceOf<T> = Zero::zero();
let mut deposit_sum: crate::BalanceOf<T> = Zero::zero();

for (code_hash, old_code_info) in prev_map {
deposit_sum.saturating_add(old_code_info.deposit);
deposit_sum = deposit_sum.saturating_add(old_code_info.deposit);
Self::assert_migrated_code_info(code_hash, &old_code_info);
}

Expand Down
Loading