relay-sproof-builder/test: Fix num of descendants#10616
Merged
Conversation
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Contributor
Author
|
/cmd prdoc --audience node_dev --bump patch |
lexnv
added
the
A4-backport-stable2512
…e_dev --bump patch'
bkchr
approved these changes
Dec 11, 2025
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Maybe you should have added a test :D
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
into_state_root_proof_and_descendants builder Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Contributor
|
Looks good! Can we consider #9886 fixed by this? |
skunert
approved these changes
Dec 15, 2025
Member
No. We can use this to fix the issue. |
paritytech-release-backport-bot Bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
This PR fixes a testing off-by-one error which causes the `sproof-builder` to build an extra descendant. While at it, have added a few detailed tests to double-check that the proper number of headers is produced. --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit ec03705)
|
Successfully created backport PR for |
EgorPopelyaev
pushed a commit
that referenced
this pull request
Dec 16, 2025
Backport #10616 into `stable2512` from lexnv. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-project-automation
Bot
moved this from Todo
to Done
in [preview] release tracker
github-project-automation
Bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a testing off-by-one error which causes the
sproof-builderto build an extra descendant.While at it, have added a few detailed tests to double-check that the proper number of headers is produced.