Add retry logic to artifact download action

[DenzelPenzel]

Description

Add retry logic (3 attempts with exponential backoff) to download-artifact-extract action using conditional steps. Update zombienet_cumulus workflow to use the custom action for consistent retry behavior.

[pepoviola]

Hi @DenzelPenzel, I think we can still use the download-artifact action with a fixed number of retries. Since, I don't think we want more. than 3 retries. Maybe we can add 3 download steps and make the last two conditional run. wdyt?

[DenzelPenzel]

Hi @DenzelPenzel, I think we can still use the download-artifact action with a fixed number of retries. Since, I don't think we want more. than 3 retries. Maybe we can add 3 download steps and make the last two conditional run. wdyt?

Yes, update to conditional steps, because gh cli by default not available on some runners

[lrubasze]

LGTM with some improvement ideas :)

[lrubasze]

Just thinking that maybe we could use shell script with some loop?

Eg. Something like this with

- name: Download artifact with retry
  shell: bash
  run: |
    max_attempts=3
    attempt=1
    backoff=2
    
    while [ $attempt -le $max_attempts ]; do
      echo "Attempt $attempt of $max_attempts"
      
      if gh run download ${{ inputs.run-id }} \
         --name ${{ inputs.artifact-name }} \
         --dir ${{ inputs.extract-path }}; then
        echo "✓ Download succeeded"
        break
      fi
      
      if [ $attempt -eq $max_attempts ]; then
        echo "✗ All attempts failed"
        exit 1
      fi
      
      sleep_time=$((backoff ** (attempt - 1)))
      echo "Retrying in ${sleep_time}s..."
      sleep $sleep_time
      attempt=$((attempt + 1))
    done

Alternatively we could try to use GH retry action, eg. https://github.com/marketplace/actions/retry-step

Or just merge it and add some improvements separately :)

[alvicsam]

AFAIR the retry-step only works with run commands so it's not applicable in case of the actions/download-artifact action

[lrubasze]

Sure thing :)

[lrubasze]

LGTM with minor comment

[pepoviola]

Looks good, I think the 3 steps are ok and we can revisit if needed in the future.
Thx!