Conversation
This is required for example for parachains that require special extensions to be registered (e.g. `ProofSizeExt`) to succeed the block execution. This pull request changes the signature of `spawn_tasks` which now requires a `tracing_execute_block` parameter. If your chain is a solochain, just set the parameter to `None` or overwrite it if you need any special handling. For parachain builders, this value can be set to `cumulus_service::ParachainTracingExecuteBlock`.
The finality notification was already carrying the information about the stale heads. However, most users of the stale heads were expanding these stale heads to all the stale blocks. So, we were iterating the same forks multiple times in the node for each finality notification. Also in a possible future where we start actually pruning headers as well, expanding these forks would fail. So, this pull request is changing the finality notification to directly carry the stale blocks (which were calculated any way already).
Member
Author
|
/cmd fmt |
skunert
approved these changes
Apr 14, 2026
michalkucharczyk
approved these changes
Apr 15, 2026
Contributor
|
Review required! Latest push from author must always be reviewed |
…2' into bkchr-fast-working-2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements Block bundling aka 500ms on the node side. Right now the pull request also contains the runtime changes, but this is already its own pull request.
The main changes are in the slot-based collator. Instead of building one block per core, blocks will be build as requested and distributed over the available cores.
Closes: #9080
Closes: #8963
Closes: #6495