Skip to content

[Revive] Change default value of eth_getStorageAt #10471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TorstenStueber merged 4 commits into from
Dec 1, 2025
Merged

[Revive] Change default value of eth_getStorageAt #10471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d1408d
Change default value of eth_getStorageAt
TorstenStueber Nov 28, 2025
66c3bb8
Merge branch 'master' into 230-eth_getstorageat-should-always-return-…
TorstenStueber Nov 29, 2025
16393d8
Update from github-actions[bot] running command 'prdoc --audience run…
github-actions[bot] Nov 29, 2025
17a1d2c
Merge branch 'master' into 230-eth_getstorageat-should-always-return-…
TorstenStueber Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions prdoc/pr_10471.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
title: '[Revive] Change default value of eth_getStorageAt'
doc:
- audience: Runtime Dev
description: |-
Closes https://github.com/paritytech/contract-issues/issues/230

With this change `eth_getStorageAt` of the eth rpc always returns a 32 byte array. If the storage slot has never been written before, it returns the 32 byte zero value as the default value. Before that it was the empty array.
crates:
- name: pallet-revive-eth-rpc
bump: patch
2 changes: 1 addition & 1 deletion substrate/frame/revive/rpc/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ impl EthRpcServer for EthRpcServerImpl {
let hash = self.client.block_hash_for_tag(block).await?;
let runtime_api = self.client.runtime_api(hash);
let bytes = runtime_api.get_storage(address, storage_slot.to_big_endian()).await?;
Ok(bytes.unwrap_or_default().into())
Ok(bytes.unwrap_or([0u8; 32].into()).into())
}

async fn get_transaction_by_block_hash_and_index(
Expand Down
Loading