Remove pallet::getter usage from sassafras pallet#10460
Merged
bkchr merged 12 commits intoparitytech:masterfrom Dec 15, 2025
Merged
Remove pallet::getter usage from sassafras pallet#10460bkchr merged 12 commits intoparitytech:masterfrom
bkchr merged 12 commits intoparitytech:masterfrom
Conversation
seadanda
reviewed
Dec 2, 2025
Contributor
There was a problem hiding this comment.
Changes look good, although you should replace the generated functions so people who use these functions elsewhere in downstream runtimes won't break.
E.g. check out https://github.com/paritytech/polkadot-sdk/pull/6184/files
Member
You mean normal rust functions and not runtime apis. |
Contributor
|
🙈 damn yea directly contradicting myself in the same sentence. fixed |
seadanda
approved these changes
Dec 5, 2025
Contributor
seadanda
left a comment
seadanda
left a comment
There was a problem hiding this comment.
Just one nit. Thanks for your contribution!
Co-authored-by: Dónal Murray <donalm@seadanda.dev>
Contributor
|
Review required! Latest push from author must always be reviewed |
seadanda
added
T1-FRAME
bkchr
approved these changes
Dec 15, 2025
bkchr
approved these changes
Dec 15, 2025
Merged
via the queue into
paritytech:master
with commit Dec 15, 2025
974c690
242 of 251 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advances #3326