Remove pallet::getter usage from merkel mountain range pallet#10437
Merged
bkchr merged 8 commits intoparitytech:masterfrom Dec 18, 2025
Merged
Remove pallet::getter usage from merkel mountain range pallet#10437bkchr merged 8 commits intoparitytech:masterfrom
bkchr merged 8 commits intoparitytech:masterfrom
Conversation
acatangiu
reviewed
Nov 26, 2025
naijauser
changed the title
naijauser
changed the title
naijauser
changed the title
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump minor |
…time_dev --bump minor'
bkchr
approved these changes
Dec 17, 2025
bkchr
reviewed
Dec 17, 2025
Co-authored-by: Bastian Köcher <git@kchr.de>
Contributor
Author
|
Hi @bkchr, should the functions be completely removed every time? In some PRs, I see that it is encouraged to keep them for backwards compatibility. |
Member
Yeah we actually keep them everywhere for backwards compatibility, but as @acatangiu already told you the opposite, I don't wanted to come in again and say the opposite again 🙈 But, if you could add them back, that would be really good and then this change is also just a |
Contributor
Author
|
Ah, okay. 😆 Let me add them back for uniformity. Cc @acatangiu |
acatangiu
approved these changes
Dec 18, 2025
Merged
via the queue into
paritytech:master
with commit Dec 18, 2025
e82044e
251 of 260 checks passed
github-project-automation
Bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advances #3326