Skip to content

Enable force debug in revive dev node #10383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TorstenStueber merged 6 commits into from
Nov 21, 2025
Merged

Enable force debug in revive dev node #10383

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1a5c9cb
Enable force debug in revive dev node
TorstenStueber Nov 21, 2025
b04f267
Update from github-actions[bot] running command 'prdoc --audience run…
github-actions[bot] Nov 21, 2025
47c741a
Add Cargo lockfile
TorstenStueber Nov 21, 2025
bd8d609
Merge branch 'torsten/force-debug' of github.com:paritytech/polkadot-…
TorstenStueber Nov 21, 2025
a67140c
Update from github-actions[bot] running command ' fmt'
github-actions[bot] Nov 21, 2025
4cfcfbf
add missing std feature
pgherveou Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions prdoc/pr_10383.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
title: Enable force debug in revive dev node
doc:
- audience: Runtime Dev
description: "This change ensures that all types that implement `RuntimeDebug` are\
\ fully displayed in log output of the revive dev node, instead of just showing\
\ `<wasm:stripped>`.\n\nUnfortunately, the trait `RuntimeDebugNoBound`, that we\
\ also use frequently in pallet-revive, is not affected and will still output\
\ `<wasm:stripped>` (it does not check for the `force-debug` feature flag, instead\
\ it only fully outputs values when either one of the features `std` or `try_runtime`\
\ is enabled \u2013\_this is something we implement as a general change)."
crates:
- name: revive-dev-runtime
bump: patch
1 change: 1 addition & 0 deletions substrate/frame/revive/dev-node/runtime/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ repository.workspace = true
edition.workspace = true

[dependencies]
sp-debug-derive = { workspace = true, features = ["force-debug"] }

@pgherveou pgherveou Nov 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature impact release build as well?

I guess the only down side is bigger runtime wasm which is fine as long as it's under the limit

@TorstenStueber TorstenStueber Nov 21, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does. Are we worried that the runtime is bigger for the dev node?

@xermicus xermicus Nov 21, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we care about debug and release builds. But does it impact the production build?

array-bytes = { workspace = true }
codec = { workspace = true }
polkadot-sdk = { workspace = true, features = [
Expand Down
Loading