ZN test for asserting building Parablocks on RC with session change#10204
Merged
ZN test for asserting building Parablocks on RC with session change#10204
Conversation
skunert
reviewed
Nov 5, 2025
Contributor
skunert
left a comment
skunert
left a comment
There was a problem hiding this comment.
Overall looks like its checking what its supposed to check (except the comment). These complicated conditions are not super easy to check sadly, so we need this boilerplate.
skunert
reviewed
Nov 7, 2025
Sajjon
force-pushed
the
cyon/assert_builds_on_rc_parent_in_old_session
branch
from
a856389 to
0bc8f94
Compare
…sion # Conflicts: # Cargo.lock # cumulus/zombienet/zombienet-sdk/Cargo.toml
Contributor
|
/cmd prdoc --audience node_dev --bump minor |
skunert
changed the title
skunert
added
the
R0-no-crate-publish-required
Contributor
|
Simplified the logic a bit and merged it with the original offset assertion. Also extended the block amount so we see some more session changes. |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
bkchr
reviewed
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit by @skunert (edited because original test said not to merge):
This adds a zombienet test that verifies that parachains running with a relay parent offset will not build on relay parents that have a session change in the descendant blocks.
The reason is that candidates that were build in a past session are dropped on session boundary.