Improve Warp Sync Logging#10196
Merged
skunert merged 24 commits intoparitytech:masterfrom Jan 5, 2026
Merged
Conversation
Contributor
Author
|
pls review @bkchr |
bkchr
reviewed
Dec 12, 2025
bkchr
approved these changes
Dec 20, 2025
Member
bkchr
left a comment
There was a problem hiding this comment.
Some last nitpicks, otherwise looks good to me.
Member
|
@runcomet please also add a prdoc |
Contributor
Author
|
pls review @bkchr in let progress_text = if let Some(ref status) = warp.status {
format!(" {}, {:.2} Mib", status, total_mib)
} else {
format!(" {:.2} Mib", total_mib)
}; |
bkchr
approved these changes
Jan 1, 2026
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <git@kchr.de>
skunert
reviewed
Jan 5, 2026
Contributor
Author
|
Suggestions have been implemented, please review @skunert @michalkucharczyk |
michalkucharczyk
approved these changes
Jan 5, 2026
skunert
approved these changes
Jan 5, 2026
Merged
via the queue into
paritytech:master
with commit Jan 5, 2026
3bfc6ec
244 of 249 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6747
This PR enhances warp sync progress reporting by:
Removing irrelevant data: Eliminates the misleading best and finalized block numbers that remain at #0 during warp sync.
Adding meaningful progress tracking: Shows the number of eras verified using
proof.proofs.len() as u64to give users clear progress indication.Updating log format: Changes from confusing static data to dynamic progress like
"15 eras synced, 2.45 MiB"