Skip to content

Improve Warp Sync Logging#10196

Merged
skunert merged 24 commits intoparitytech:masterfrom
runcomet:WSL
Jan 5, 2026
Merged

Improve Warp Sync Logging#10196
skunert merged 24 commits intoparitytech:masterfrom
runcomet:WSL

Conversation

@runcomet
Copy link
Copy Markdown
Contributor

@runcomet runcomet commented Nov 4, 2025

Resolves #6747

This PR enhances warp sync progress reporting by:

  • Removing irrelevant data: Eliminates the misleading best and finalized block numbers that remain at #0 during warp sync.

  • Adding meaningful progress tracking: Shows the number of eras verified using proof.proofs.len() as u64 to give users clear progress indication.

  • Updating log format: Changes from confusing static data to dynamic progress like "15 eras synced, 2.45 MiB"

@runcomet runcomet marked this pull request as ready for review November 5, 2025 12:02
@runcomet runcomet changed the title Improve Warp Sync Logs Improve Warp Sync Logging Nov 5, 2025
@runcomet
Copy link
Copy Markdown
Contributor Author

runcomet commented Nov 5, 2025

pls review @bkchr

Copy link
Copy Markdown
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay

Comment thread substrate/client/informant/src/display.rs Outdated
Comment thread substrate/client/informant/src/display.rs Outdated
@runcomet runcomet requested a review from bkchr December 20, 2025 07:05
Copy link
Copy Markdown
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some last nitpicks, otherwise looks good to me.

Comment thread substrate/client/informant/src/display.rs Outdated
Comment thread substrate/client/consensus/grandpa/src/warp_proof.rs Outdated
@bkchr bkchr requested a review from a team December 20, 2025 20:19
@bkchr bkchr added the T0-node This PR/Issue is related to the topic “node”. label Dec 20, 2025
@bkchr
Copy link
Copy Markdown
Member

bkchr commented Dec 20, 2025

@runcomet please also add a prdoc

@runcomet
Copy link
Copy Markdown
Contributor Author

pls review @bkchr

in display.rs I added similar spacing as seen for Downloading and Importing SyncState

let progress_text = if let Some(ref status) = warp.status {
    format!(" {}, {:.2} Mib", status, total_mib)
} else {
    format!(" {:.2} Mib", total_mib)
};

Comment thread substrate/client/consensus/grandpa/src/warp_proof.rs Outdated
Comment thread substrate/client/consensus/grandpa/src/warp_proof.rs Outdated
Comment thread substrate/client/informant/src/display.rs Outdated
Comment thread substrate/client/informant/src/display.rs Outdated
runcomet and others added 2 commits January 1, 2026 23:46
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <git@kchr.de>
runcomet and others added 4 commits January 1, 2026 23:47
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <git@kchr.de>
@bkchr bkchr requested a review from a team January 4, 2026 21:05
Comment thread substrate/client/informant/src/display.rs Outdated
Comment thread substrate/client/consensus/grandpa/src/warp_proof.rs Outdated
Comment thread prdoc/pr_10196.prdoc Outdated
Comment thread substrate/client/informant/src/display.rs Outdated
@runcomet
Copy link
Copy Markdown
Contributor Author

runcomet commented Jan 5, 2026

Suggestions have been implemented, please review @skunert @michalkucharczyk

@skunert skunert added this pull request to the merge queue Jan 5, 2026
Merged via the queue into paritytech:master with commit 3bfc6ec Jan 5, 2026
244 of 249 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T0-node This PR/Issue is related to the topic “node”.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Improve Warp Sync Logs

5 participants