Skip to content

Upgrade litep2p 0.10.0 -> 0.11.0#10056

Merged
bkontur merged 6 commits into
masterfrom
dm-upgrade-litep2p-v0.11.0
Oct 20, 2025
Merged

Upgrade litep2p 0.10.0 -> 0.11.0#10056
bkontur merged 6 commits into
masterfrom
dm-upgrade-litep2p-v0.11.0

Conversation

@dmitry-markin
Copy link
Copy Markdown
Contributor

@dmitry-markin dmitry-markin commented Oct 20, 2025

This upgrade fixes the initialization of mDNS in the environment with no multicast addresses available and compatibility with kubo IPFS >= 0.37 when run with --ipfs-server. It also enables communication with remote peers having RSA network identity keys.

@dmitry-markin dmitry-markin self-assigned this Oct 20, 2025
@dmitry-markin dmitry-markin added the T0-node This PR/Issue is related to the topic “node”. label Oct 20, 2025
@dmitry-markin
Copy link
Copy Markdown
Contributor Author

/cmd prdoc --audience node_dev --bump patch

Copy link
Copy Markdown
Contributor

@bkontur bkontur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmitry-markin It would be cool to have some “conformance” tests for Bitswap — do you think something like that is possible and makes sense?

Alternatively, we could set up tests for the different Kubo versions, but that’s probably not ideal 🙂. Just trying to avoid situations like we had here with different Kubo version :)

@dmitry-markin
Copy link
Copy Markdown
Contributor Author

@dmitry-markin It would be cool to have some “conformance” tests for Bitswap — do you think something like that is possible and makes sense?

Alternatively, we could set up tests for the different Kubo versions, but that’s probably not ideal 🙂. Just trying to avoid situations like we had here with different Kubo version :)

I can hardly think of any other conformance test than with actual 3rd-party IPFS client (i.e., kubo). But, as it turned out, this doesn't always guarantee the implementation is bug-free and is not "just working with a specific client".

@dmitry-markin dmitry-markin added this pull request to the merge queue Oct 20, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 20, 2025
@bkontur bkontur enabled auto-merge October 20, 2025 14:38
@bkontur bkontur added this pull request to the merge queue Oct 20, 2025
Merged via the queue into master with commit 17d70f2 Oct 20, 2025
243 of 244 checks passed
@bkontur bkontur deleted the dm-upgrade-litep2p-v0.11.0 branch October 20, 2025 15:46
@github-project-automation github-project-automation Bot moved this to Blocked ⛔️ in Networking Oct 20, 2025
@bkontur
Copy link
Copy Markdown
Contributor

bkontur commented Oct 21, 2025

@dmitry-markin It would be cool to have some “conformance” tests for Bitswap — do you think something like that is possible and makes sense?
Alternatively, we could set up tests for the different Kubo versions, but that’s probably not ideal 🙂. Just trying to avoid situations like we had here with different Kubo version :)

I can hardly think of any other conformance test than with actual 3rd-party IPFS client (i.e., kubo). But, as it turned out, this doesn't always guarantee the implementation is bug-free and is not "just working with a specific client".

@dmitry-markin please, check this: paritytech/polkadot-bulletin-chain#76 (comment), I still think that adding some more tests is pretty worth, I created an issue with more details here: paritytech/litep2p#454

RomarQ pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Oct 28, 2025
This upgrade fixes the initialization of mDNS in the environment with no
multicast addresses available and compatibility with kubo IPFS >= 0.37
when run with `--ipfs-server`. It also enables communication with remote
peers having RSA network identity keys.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
tmpolaczyk pushed a commit to moondance-labs/polkadot-sdk that referenced this pull request Oct 28, 2025
This upgrade fixes the initialization of mDNS in the environment with no
multicast addresses available and compatibility with kubo IPFS >= 0.37
when run with `--ipfs-server`. It also enables communication with remote
peers having RSA network identity keys.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
RomarQ pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Nov 18, 2025
This upgrade fixes the initialization of mDNS in the environment with no
multicast addresses available and compatibility with kubo IPFS >= 0.37
when run with `--ipfs-server`. It also enables communication with remote
peers having RSA network identity keys.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
RomarQ pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Nov 18, 2025
This upgrade fixes the initialization of mDNS in the environment with no
multicast addresses available and compatibility with kubo IPFS >= 0.37
when run with `--ipfs-server`. It also enables communication with remote
peers having RSA network identity keys.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
RomarQ pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Nov 18, 2025
This upgrade fixes the initialization of mDNS in the environment with no
multicast addresses available and compatibility with kubo IPFS >= 0.37
when run with `--ipfs-server`. It also enables communication with remote
peers having RSA network identity keys.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
tmpolaczyk pushed a commit to moondance-labs/polkadot-sdk that referenced this pull request Jan 15, 2026
This upgrade fixes the initialization of mDNS in the environment with no
multicast addresses available and compatibility with kubo IPFS >= 0.37
when run with `--ipfs-server`. It also enables communication with remote
peers having RSA network identity keys.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T0-node This PR/Issue is related to the topic “node”.

Projects

Status: Blocked ⛔️

Development

Successfully merging this pull request may close these issues.

4 participants