[AHM/Staking] Allow own stake to be collected in all pages#10051
Merged
Conversation
kianenigma
added
A4-backport-unstable2507
Contributor
Author
|
/cmd prdoc --bump patch |
Ank4n
reviewed
Oct 19, 2025
Ank4n
approved these changes
Oct 19, 2025
sigurpol
reviewed
Oct 19, 2025
sigurpol
left a comment
sigurpol
left a comment
Contributor
There was a problem hiding this comment.
Don’t have my laptop with me so I did look only at code diff on mobile , changes sound proper but it’s definitely not an accurate review as I would love to have at this stage and time pre PAHM. Hopefully unlike me, @Ank4n can double check everything properly.
Also the current bug is maybe something we would like to add to the checklist of the long running staking test we are deploying for AHM
sigurpol
approved these changes
Oct 19, 2025
seadanda
approved these changes
Oct 20, 2025
seadanda
left a comment
seadanda
left a comment
Contributor
There was a problem hiding this comment.
Upgrading Ankan's review. Also passed sanity check, but I'm missing some context
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
franciscoaguirre
approved these changes
Oct 20, 2025
franciscoaguirre
left a comment
franciscoaguirre
left a comment
Contributor
There was a problem hiding this comment.
For what it's worth, looks good overall
andreitrand
approved these changes
Oct 20, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
Successfully created backport PR for |
paritytech-release-backport-bot Bot
pushed a commit
that referenced
this pull request
Oct 20, 2025
TLDR: Thanks to a number of reports from Kusama validator, we have been investigating an issue where the self stake of some validators is not present in `ErasStakersPaged` and `ErasStakersOverview`, and consequently not earning staking rewards. After investigation, it was clear that the `polkadot-staking-miner` is doing the right thing, and the self-stake is indeed submitted to the chain as a part of the staking election result. The root cause in how `pallet-staking-async` ingests the staking election result. This code **made a (wrong) assumption that self-stake is only present in the first page of a multi-page election. This PR fixes this issue.** --- - [x] (nice to have) revisit try-state checks of the pallet, `ErasStakersPaged`, `ErasStakersOverview` and `ErasTotalStake` are triple checked for correctness - [ ] (nice to have) fix related displays in PJS: polkadot-js/apps#11930 - [ ] backport to 2507 and 2509 - Westend - [ ] Find a similar issue in westend for monitoring (paritytech/devops#4402) - [ ] Upgrade westend to a branch/release containing this fix - [ ] Upgrade westend with this fix, observe test examples are resolved - [ ] Bump backported version in `fellowship/runtimes` - [ ] Release 1.9.3 for Kusama with this fix - [ ] Ensure known test cases are fixed - One example: `F2WyUUFXLYnBg6acv7t2KFzH6D7CyNcvC4mRCwUdsHTUB4t` (in election round 46, likely repeating in subsequent ones too) - This PR will be part of Polkadot release 2.0.0, the Polkadot AHM. - [ ] Forum post with further explanation once PR is merged. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 56e4b10)
paritytech-release-backport-bot Bot
pushed a commit
that referenced
this pull request
Oct 20, 2025
TLDR: Thanks to a number of reports from Kusama validator, we have been investigating an issue where the self stake of some validators is not present in `ErasStakersPaged` and `ErasStakersOverview`, and consequently not earning staking rewards. After investigation, it was clear that the `polkadot-staking-miner` is doing the right thing, and the self-stake is indeed submitted to the chain as a part of the staking election result. The root cause in how `pallet-staking-async` ingests the staking election result. This code **made a (wrong) assumption that self-stake is only present in the first page of a multi-page election. This PR fixes this issue.** --- - [x] (nice to have) revisit try-state checks of the pallet, `ErasStakersPaged`, `ErasStakersOverview` and `ErasTotalStake` are triple checked for correctness - [ ] (nice to have) fix related displays in PJS: polkadot-js/apps#11930 - [ ] backport to 2507 and 2509 - Westend - [ ] Find a similar issue in westend for monitoring (paritytech/devops#4402) - [ ] Upgrade westend to a branch/release containing this fix - [ ] Upgrade westend with this fix, observe test examples are resolved - [ ] Bump backported version in `fellowship/runtimes` - [ ] Release 1.9.3 for Kusama with this fix - [ ] Ensure known test cases are fixed - One example: `F2WyUUFXLYnBg6acv7t2KFzH6D7CyNcvC4mRCwUdsHTUB4t` (in election round 46, likely repeating in subsequent ones too) - This PR will be part of Polkadot release 2.0.0, the Polkadot AHM. - [ ] Forum post with further explanation once PR is merged. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 56e4b10)
|
Successfully created backport PR for |
kianenigma
added a commit
that referenced
this pull request
Oct 20, 2025
Backport #10051 into `unstable2507` from kianenigma. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kianenigma
added a commit
that referenced
this pull request
Oct 20, 2025
Backport #10051 into `stable2509` from kianenigma. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/psa-disruption-to-kusama-validators-self-stake-and-rewards/15599/1 |
fellowship-merge-bot Bot
pushed a commit
to polkadot-fellows/runtimes
that referenced
this pull request
Oct 21, 2025
Brings paritytech/polkadot-sdk#10051 to here, to be made into a 1.9.3 release for Kusama. Can be merged, but a 1.9.3 release should come only after we verify the fix in westend. --------- Co-authored-by: Dónal Murray <donalm@seadanda.dev>
github-project-automation
Bot
moved this from Todo
to Done
in [preview] release tracker
github-project-automation
Bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: Thanks to a number of reports from Kusama validator, we have been investigating an issue where the self stake of some validators is not present in
ErasStakersPagedandErasStakersOverview, and consequently not earning staking rewards.After investigation, it was clear that the
polkadot-staking-mineris doing the right thing, and the self-stake is indeed submitted to the chain as a part of the staking election result.The root cause in how
pallet-staking-asyncingests the staking election result. This code made a (wrong) assumption that self-stake is only present in the first page of a multi-page election. This PR fixes this issue.ErasStakersPaged,ErasStakersOverviewandErasTotalStakeare triple checked for correctnessfellowship/runtimes: Bumppallet-staking-asyncto0.6.2polkadot-fellows/runtimes#980F2WyUUFXLYnBg6acv7t2KFzH6D7CyNcvC4mRCwUdsHTUB4t(in election round 46, likely repeating in subsequent ones too)