Skip to content

[DNM/Temp] use fast benchmark in staking election verifier#10013

Merged
kianenigma merged 7 commits into
kiz-epmb-pollfrom
kiz-epmb-fast-benches-on-poll
Nov 11, 2025
Merged

[DNM/Temp] use fast benchmark in staking election verifier#10013
kianenigma merged 7 commits into
kiz-epmb-pollfrom
kiz-epmb-fast-benches-on-poll

Conversation

@kianenigma

@kianenigma kianenigma commented Oct 14, 2025

Copy link
Copy Markdown
Contributor

On top of just to see the weight diff with different bench config
Solving issues in polkadot-fellows/runtimes#959 and polkadot-fellows/runtimes#963

@kianenigma

kianenigma commented Oct 14, 2025

Copy link
Copy Markdown
Contributor Author

/cmd bench --pallet pallet_election_provider_multi_block pallet_election_provider_multi_block_signed pallet_election_provider_multi_block_verifier pallet_election_provider_multi_block_unsigned --runtime asset-hub-westend

@github-actions

github-actions Bot commented Oct 14, 2025

Copy link
Copy Markdown
Contributor

Command "bench --pallet pallet_election_provider_multi_block pallet_election_provider_multi_block_signed pallet_election_provider_multi_block_verifier pallet_election_provider_multi_block_unsigned --runtime asset-hub-westend" has started 🚀 See logs here

@github-actions
Update from github-actions[bot] running command 'bench --pallet palle…
da34387 
…t_election_provider_multi_block pallet_election_provider_multi_block_signed pallet_election_provider_multi_block_verifier pallet_election_provider_multi_block_unsigned --runtime asset-hub-westend'
@github-actions

github-actions Bot commented Oct 14, 2025

Copy link
Copy Markdown
Contributor

Command "bench --pallet pallet_election_provider_multi_block pallet_election_provider_multi_block_signed pallet_election_provider_multi_block_verifier pallet_election_provider_multi_block_unsigned --runtime asset-hub-westend" has finished ✅ See logs here

Details

Subweight results:
File Extrinsic Old New Change [%]
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_dot_size.rs manage 290.00ns 310.00ns +6.90
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_unsigned_ksm_size.rs submit_unsigned 31.86ms 29.74ms -6.63
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_bags_list.rs on_idle 9.22ms 8.54ms -7.38
substrate/frame/bags-list/src/weights.rs on_idle 8.85ms 8.17ms -7.72
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_unsigned_dot_size.rs submit_unsigned 28.69ms 21.97ms -23.44
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_unsigned_ksm_size.rs validate_unsigned 2.48ms 1.33ms -46.16
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_signed_ksm_size.rs unset_page 2.76ms 766.20us -72.24
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_signed_ksm_size.rs submit_page 2.96ms 798.46us -73.01
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_unsigned_dot_size.rs validate_unsigned 4.06ms 1.08ms -73.32
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_signed_dot_size.rs submit_page 6.92ms 829.09us -88.02
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_signed_dot_size.rs unset_page 8.56ms 788.78us -90.79
substrate/frame/revive/src/weights.rs seal_take_storage 135.91us Added
substrate/frame/revive/src/weights.rs seal_contains_storage 33.82us Added
substrate/frame/revive/src/weights.rs seal_clear_storage 134.87us Added
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_verifier_ksm_size.rs verification_valid_terminal 22.96ms Added
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_verifier_ksm_size.rs verification_valid_non_terminal 5.89ms Added
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_verifier_ksm_size.rs verification_invalid_terminal 24.96ms Added
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_verifier_ksm_size.rs verification_invalid_non_terminal 8.37ms Added
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_verifier_dot_size.rs verification_valid_terminal 26.50ms Added
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_verifier_dot_size.rs verification_valid_non_terminal 5.13ms Added
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_verifier_dot_size.rs verification_invalid_terminal 30.27ms Added
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_verifier_dot_size.rs verification_invalid_non_terminal 14.59ms Added
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_ksm_size.rs per_block_start_signed_validation 338.10us Added
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_ksm_size.rs per_block_snapshot_rest 140.92ms Added
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_ksm_size.rs per_block_snapshot_msp 85.21ms Added
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_ksm_size.rs per_block_nothing 162.02us Added
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_dot_size.rs per_block_start_signed_validation 339.27us Added
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_dot_size.rs per_block_snapshot_rest 124.14ms Added
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_dot_size.rs per_block_snapshot_msp 67.85ms Added
substrate/frame/election-provider-multi-block/src/weights/pallet_election_provider_multi_block_dot_size.rs per_block_nothing 162.29us Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_election_provider_multi_block_verifier.rs verification_valid_terminal 10.35ms Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_election_provider_multi_block_verifier.rs verification_valid_non_terminal 1.35ms Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_election_provider_multi_block_verifier.rs verification_invalid_terminal 14.11ms Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_election_provider_multi_block_verifier.rs verification_invalid_non_terminal 13.72ms Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_election_provider_multi_block_unsigned.rs validate_unsigned 222.53us Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_election_provider_multi_block_unsigned.rs submit_unsigned 1.88ms Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_election_provider_multi_block_signed.rs unset_page 650.46us Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_election_provider_multi_block_signed.rs submit_page 671.24us Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_election_provider_multi_block_signed.rs register_not_full 510.20us Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_election_provider_multi_block_signed.rs register_eject 4.90ms Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_election_provider_multi_block_signed.rs clear_old_round_data 4.55ms Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_election_provider_multi_block_signed.rs bail 4.57ms Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_election_provider_multi_block.rs per_block_start_signed_validation 284.05us Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_election_provider_multi_block.rs per_block_snapshot_rest 107.65ms Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_election_provider_multi_block.rs per_block_snapshot_msp 31.69ms Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_election_provider_multi_block.rs per_block_nothing 157.81us Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_election_provider_multi_block.rs manage 229.00ns Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_election_provider_multi_block.rs export_terminal 13.51ms Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_election_provider_multi_block.rs export_non_terminal 558.77us Added
Command output:

✅ Successful benchmarks of runtimes/pallets:
-- asset-hub-westend: ['pallet_election_provider_multi_block', 'pallet_election_provider_multi_block_signed', 'pallet_election_provider_multi_block_verifier', 'pallet_election_provider_multi_block_unsigned']

@sigurpol

sigurpol commented Oct 14, 2025

Copy link
Copy Markdown
Contributor

I believe we should still benchmark unsigned pallet mine_solution() benchmark here with the real solver otherwise I am afraid we would obtain not realistic results for that specific benchmark. All other benchmarks under EPMB if I am not wrong, are mining a solution outside #[block] so we should be good with the quick solver

kianenigma
kianenigma commented Oct 14, 2025
View reviewed changes
Comment thread substrate/frame/election-provider-support/src/lib.rs Outdated
kianenigma
kianenigma commented Oct 14, 2025
View reviewed changes

@kianenigma kianenigma left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All weight diffs look small, good.

@kianenigma

kianenigma commented Oct 14, 2025

Copy link
Copy Markdown
Contributor Author

I believe we should still benchmark unsigned pallet mine_solution() benchmark here with the real solver otherwise I am afraid we would obtain not realistic results for that specific benchmark. All other benchmarks under EPMB if I am not wrong, are mining a solution outside #[block] so we should be good with the quick solver

Ah yeah, great point. Although, this benchmark is #[extra] and not used anywhere. It it is just there to give us a sense of how long the OCW miner will take when executing the miner in wasm.

@kianenigma

kianenigma commented Oct 14, 2025

Copy link
Copy Markdown
Contributor Author

Honestly I don't like the fact that we had to use the type Solver at the global level here, I wish we could do it more granular, but don't think it is possible.

@sigurpol

sigurpol commented Oct 14, 2025

Copy link
Copy Markdown
Contributor

Ah yeah, great point. Although, this benchmark is #[extra] and not used anywhere. It it is just there to give us a sense of how long the OCW miner will take when executing the miner in wasm.

yes, definitely so I think the quick and dirty solver is a neat approach. That said, I also agree it would be nice to be able to specify solver with more granularity

@kianenigma

kianenigma commented Oct 15, 2025

Copy link
Copy Markdown
Contributor Author

gonna merge this actually after the base branch is merged, or merge it into base if being lazy.

@kianenigma kianenigma marked this pull request as ready for review November 4, 2025 19:50
@kianenigma kianenigma requested a review from a team as a code owner November 4, 2025 19:50
@paritytech-workflow-stopper

paritytech-workflow-stopper Bot commented Nov 4, 2025

Copy link
Copy Markdown

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/19081005722
Failed job name: build-subkey

@kianenigma kianenigma merged commit fdd5b3b into kiz-epmb-poll Nov 11, 2025
232 of 323 checks passed
@kianenigma kianenigma deleted the kiz-epmb-fast-benches-on-poll branch November 11, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sigurpol sigurpol sigurpol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kianenigma @sigurpol