Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling an address without associated code should do a balance transfer #5577

Closed
Tracked by #13
athei opened this issue Sep 3, 2024 · 0 comments · Fixed by #5664
Closed
Tracked by #13

Calling an address without associated code should do a balance transfer #5577

athei opened this issue Sep 3, 2024 · 0 comments · Fixed by #5664
Assignees
@athei

Comments

@athei
Copy link
Member

athei commented Sep 3, 2024

No description provided.

@athei athei mentioned this issue Nov 28, 2024
Closed
@athei athei self-assigned this Sep 3, 2024
@athei athei mentioned this issue Sep 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 11, 2024
@athei @xermicus
Send balance when contract doesn't exist (#5664)
ea5fb02 
Fixes #5577 

I decided to bubble up the error from where we actually try to load the
contract info. This helps to make sure that we don't miss some entry
point by accident. The draw back is that we have to live with some
additional `.expect`.

@pgherveou With this logic the proxy and its runtime part should be
completely unaware whether something is a contract call or a balance
transfer. They should just route everything into pallet_revive.

---------

Co-authored-by: Cyrill Leutwiler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athei athei

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Send balance when contract doesn't exist paritytech/polkadot-sdk
1 participant
@athei