Skip to content

Move request-response handling from ChainSync to SyncingEngine #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #534
dmitry-markin opened this issue Jun 14, 2023 · 0 comments · Fixed by #1650
Closed
Tracked by #534

Move request-response handling from ChainSync to SyncingEngine #502

dmitry-markin opened this issue Jun 14, 2023 · 0 comments · Fixed by #1650
Assignees
@dmitry-markin
Labels
I4-refactor Code needs refactoring.

Comments

@dmitry-markin
Copy link
Contributor

Move request-respone handling from ChainSync to SyncingEngine.

This issue is a part of Sync 2.0 (#534) preparation work aimed at making ChainSync a pure state machine.
@dmitry-markin dmitry-markin self-assigned this Jun 14, 2023
@arkpar arkpar mentioned this issue Aug 24, 2023
Open
@altonen altonen transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I4-refactor Code needs refactoring. and removed I7-refactor labels Aug 25, 2023
@dmitry-markin dmitry-markin mentioned this issue Sep 20, 2023
Merged
dmitry-markin added a commit that referenced this issue Sep 27, 2023
@dmitry-markin @altonen @bkchr
Move requests-responses and polling from ChainSync to `SyncingEngin…
14e5d23 
…e` (#1650)

Move request-response handling from `ChainSync` to `SyncingEngine` as
part of [Sync
2.0](#534) refactoring
aimed at making `ChainSync` a pure state machine.

Resolves #502.

---------

Co-authored-by: Aaro Altonen <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
@github-project-automation github-project-automation bot moved this from Backlog 🗒 to Blocked ⛔️ in Networking Sep 27, 2023
@altonen altonen moved this from Blocked ⛔️ to Done ✅ in Networking Jan 2, 2024
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
@dmitry-markin @altonen @bkchr
Move requests-responses and polling from ChainSync to `SyncingEngin…
9ff402b 
…e` (paritytech#1650)

Move request-response handling from `ChainSync` to `SyncingEngine` as
part of [Sync
2.0](paritytech#534) refactoring
aimed at making `ChainSync` a pure state machine.

Resolves paritytech#502.

---------

Co-authored-by: Aaro Altonen <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitry-markin dmitry-markin

Labels
I4-refactor Code needs refactoring.
Projects
Networking
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move requests-responses and polling from ChainSync to SyncingEngine paritytech/polkadot-sdk
2 participants
@dmitry-markin @the-right-joyce